AJAX page visibility actions WIP 2

james-cnz · james-cnz · commit 8244207f6b3b · 2025-06-25T12:51:40.000+12:00
diff --git a/classes/courseformat/stateactions.php b/classes/courseformat/stateactions.php
@@ -299,10 +299,10 @@ protected function set_section_visibility(
             }
             if (!$visible && $sectionextra->section || $visible && $sectionextra->parentvisiblesan) {
                 for ($subsectionextra = $sectionextra; /* ... */
-                        $subsectionextra && ($subsectionextra->id == $sectionextra->id
-                                            || $subsectionextra->levelsan > $sectionextra->levelsan); /* ... */
+                        $subsectionextra && (($subsectionextra->id == $sectionextra->id)
+                                            || ($subsectionextra->levelsan > $sectionextra->levelsan)); /* ... */
                         $subsectionextra = $subsectionextra->nextanyid ? $allsectionsextra[$subsectionextra->nextanyid] : null) {
-                    if ($subsectionextra->id == $sectionextra->id || !$visible) {
+                    if (($subsectionextra->id == $sectionextra->id) || !$visible) {
                         course_update_section($course, $subsectionextra->sectionbase, ['visible' => $visible]);
                     }
                     $subids[] = $subsectionextra->id;

Original file line number	Diff line number	Diff line change
`@@ -299,10 +299,10 @@ protected function set_section_visibility(`
`299`	`299`	`}`
`300`	`300`	`if (!$visible && $sectionextra->section \|\| $visible && $sectionextra->parentvisiblesan) {`
`301`	`301`	`for ($subsectionextra = $sectionextra; /* ... */`
`302`		`- $subsectionextra && ($subsectionextra->id == $sectionextra->id`
`303`		`- \|\| $subsectionextra->levelsan > $sectionextra->levelsan); /* ... */`
	`302`	`+ $subsectionextra && (($subsectionextra->id == $sectionextra->id)`
	`303`	`+ \|\| ($subsectionextra->levelsan > $sectionextra->levelsan)); /* ... */`
`304`	`304`	`$subsectionextra = $subsectionextra->nextanyid ? $allsectionsextra[$subsectionextra->nextanyid] : null) {`
`305`		`- if ($subsectionextra->id == $sectionextra->id \|\| !$visible) {`
	`305`	`+ if (($subsectionextra->id == $sectionextra->id) \|\| !$visible) {`
`306`	`306`	`course_update_section($course, $subsectionextra->sectionbase, ['visible' => $visible]);`
`307`	`307`	`}`
`308`	`308`	`$subids[] = $subsectionextra->id;`