Create section method (MDL-80187) WIP 9

Author: james-cnz

classes/courseformat/sectionactions.php

@@ -32,6 +32,8 @@ class sectionactions extends base_sectionactions {
     /**
      * Create a course section using a record object.
      *
+     * If no position is specified, the section is added to the end of the course.
+     *
      * @param stdClass $fields the fields to set on the section
      * @param bool $skipcheck the position check has already been made and we know it can be used
      * @return stdClass the created section record
@@ -73,7 +75,7 @@ public function fmt_create_from_object(stdClass $fields, bool $skipcheck = false
             'timemodified' => time(),
         ];
         $sectionrecord->id = $DB->insert_record("course_sections", $sectionrecord);
-        if (empty($fields->component) && !($skipcheck && ($createnum > 0))) {
+        if (empty($fields->component) && !($skipcheck && ($fields->section > 0))) {
             $DB->insert_record("course_format_options", [
                 'courseid' => $this->course->id,
                 'format' => 'multitopic',
@@ -84,7 +86,8 @@ public function fmt_create_from_object(stdClass $fields, bool $skipcheck = false
         }
 
         // Now move it to the specified position, if necessary.
-        if (!$skipcheck && !(!empty($fields->component) && property_exists($fields, 'nextupid') && ($fields->nextupid == null))) {
+        $skipmove = $skipcheck || !empty($fields->component) && property_exists($fields, 'nextupid') && ($fields->nextupid == null);
+        if (!$skipmove) {
             try {
                 $movednews = format_multitopic_move_section_to(
                                 $this->course, [$sectionrecord], $fields, !empty($fields->component) ? 2 : 1