Create section method (MDL-80187) WIP 5

Author: james-cnz

classes/courseformat/sectionactions.php

@@ -83,7 +83,6 @@ public function create_from_object(stdClass $fields, bool $skipcheck = false): s
         // Now move it to the specified position, if necessary.
         if (!$skipcheck && !(!empty($fields->component) && property_exists($fields, 'nextid') && $fields->nextid == null)) {
             try {
-                rebuild_course_cache($this->course->id, true);
                 $movednews = format_multitopic_move_section_to(
                                 $this->course, [$sectionrecord], $fields, !empty($fields->component) ? 2 : 1
                             );

locallib.php

@@ -49,6 +49,7 @@ function format_multitopic_move_section_to(\stdClass $course, $origins, \stdClas
     // REMOVED.
 
     // Get all sections for this course and re-order them.
+    rebuild_course_cache($course->id, true);
     if (!$sectionsextra = course_get_format($course)->fmt_get_sections_extra()) { // CHANGED.
         throw new \moodle_exception('cannotcreateorfindstructs');               // CHANGED.
     }