SR-OS: Inter-VRF route leaking does not work

Implemented a 'vdata._leaked_routes' flag in the VRF module to avoid
duplicate work and used it for an SR-OS device quirk

Author: ipspace

netsim/devices/sros.py

@@ -17,11 +17,20 @@ def ipv4_unnumbered(node: Box) -> None:
         node=node,
         category=log.IncorrectValue)
 
+def vrf_route_leaking(node: Box) -> None:
+  for vname,vdata in node.get('vrfs',{}).items():
+    if '_leaked_routes' in vdata:
+      report_quirk(
+        text=f'We did not implement inter-VRF route leaking on SR/OS (node {node.name} vrf {vname})',
+        node=node,
+        category=log.IncorrectValue)
+
 class SROS(_Quirks):
 
   @classmethod
   def device_quirks(self, node: Box, topology: Box) -> None:
     ipv4_unnumbered(node)
+    vrf_route_leaking(node)
 
   def check_config_sw(self, node: Box, topology: Box) -> None:
     need_ansible_collection(node,'nokia.grpc',version='1.0.2')

netsim/modules/vrf.py

@@ -290,6 +290,7 @@ def validate_vrf_route_leaking(node : Box) -> None:
     leaked_routes = vdata['import'] and vdata['import'] != simple_rt
     leaked_routes = leaked_routes or (vdata['export'] and vdata['export'] != simple_rt)
     if leaked_routes:
+      vdata._leaked_routes = True
       if not node.get('bgp.as',None):
         if node.get('vrf.as',None):
           node.bgp['as'] = node.vrf['as']

tests/topology/expected/evpn-hub-spoke.yml

@@ -122,6 +122,7 @@ nodes:
       as: 65000
     vrfs:
       hub:
+        _leaked_routes: true
         af:
           ipv4: true
         bgp:
@@ -215,6 +216,7 @@ nodes:
       as: 65000
     vrfs:
       spoke:
+        _leaked_routes: true
         af:
           ipv4: true
         bgp:

tests/topology/expected/vrf.yml

@@ -366,6 +366,7 @@ nodes:
       as: 65000
     vrfs:
       black:
+        _leaked_routes: true
         af:
           ipv4: true
         bgp: