Skip to content

Commit 3063ed4

Browse files
committed
Fixing nits
1 parent 71ba4f2 commit 3063ed4

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

tests/integration/evpn/21-bgp-ce-router.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ message: |
55
External devices should be able to ping each other
66
77
defaults.sources.extra: [ ../wait_times.yml, ../warnings.yml ]
8-
plugin: [ fix_mtu ]
8+
plugin: [ fix_mtu, adjust_test ]
99

1010
module: [ vlan, vxlan, ospf, bgp, evpn, vrf ]
1111
bgp.as: 65000
@@ -47,6 +47,13 @@ links:
4747
s2:
4848
mtu: 1600
4949

50+
_adjust:
51+
- nodes: [ dut ] # Do not test the second VRF on vyos (broken) or NXOS (unknown)
52+
devices: [ vyos, nxos ]
53+
warning: The device does not work correctly with multiple L3VRFs
54+
remove:
55+
- validate.ping_ce4
56+
5057
validate:
5158
ebgp_s1:
5259
description: Check EBGP sessions CE1-DUT

tests/integration/plugin/adjust_test.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,12 @@ def check_faulty_devices(a_entry: Box, topology: Box) -> typing.Optional[Box]:
9090
if 'devices' not in a_entry:
9191
return None
9292

93+
dev_list = make_a_list(a_entry.devices)
9394
for n_name in get_a_list(a_entry,'nodes'): # Iterate over nodes to check
9495
if n_name not in topology.nodes: # Skip missing nodes
9596
continue
9697
n_data = topology.nodes[n_name] # Get node data
97-
if n_data.device in a_entry.devices: # Faulty device?
98+
if n_data.device in dev_list: # Faulty device?
9899
return n_data
99100

100101
return None
@@ -106,7 +107,7 @@ def adjust_topology(a_entry: Box, topology: Box) -> None:
106107
if n_data is None: # No missing features or faulty devices?
107108
return # Cool, we're out of here ;)
108109

109-
# The n_name/n_data contain the first node with missing feature(s)
110+
# n_data contain the first node that triggered adjustment
110111
#
111112
w_text = a_entry.get('warning','') # Do we have to add a warning?
112113
if w_text: # Print the formatted warning

0 commit comments

Comments
 (0)