Skip to content

Commit f412c44

Browse files
committed
Address code review comments
1 parent 035b366 commit f412c44

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

bindings/cpp/include/svs/runtime/version.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
///
2222
/// This header defines the SVS Runtime API versioning scheme:
2323
/// 1. Versioned namespaces (e.g., v0, v1) for API stability
24-
/// 2. Using declarations to bring current version to parent namespace
24+
/// 2. Inline namespace to expose the current API version at svs::runtime::*
2525
/// 3. Clean integration points for external libraries
2626
///
2727
/// Usage:
@@ -59,7 +59,8 @@
5959
#define SVS_RUNTIME_API_VERSION SVS_RUNTIME_VERSION_MAJOR
6060
#endif
6161

62-
#define SVS_API_VERSION_NS(version) v##version
62+
#define SVS_API_VERSION_NS_IMPL(version) v##version
63+
#define SVS_API_VERSION_NS(version) SVS_API_VERSION_NS_IMPL(version)
6364
#define SVS_RUNTIME_API_VERSION_NAMESPACE SVS_API_VERSION_NS(SVS_RUNTIME_API_VERSION)
6465

6566
#if (SVS_RUNTIME_API_VERSION == 0)
@@ -86,7 +87,8 @@ inline namespace v0 {}
8687
namespace alias_name = svs::runtime::version_ns
8788

8889
/// Helper macro to declare versioned namespaces for API definitions
89-
#define SVS_DECLARE_NAMESPACE_VERSION(version) SVS_DECLARE_NAMESPACE_VERSION_##version
90+
#define SVS_DECLARE_NAMESPACE_VERSION_IMPL(version) SVS_DECLARE_NAMESPACE_VERSION_##version
91+
#define SVS_DECLARE_NAMESPACE_VERSION(version) SVS_DECLARE_NAMESPACE_VERSION_IMPL(version)
9092

9193
///
9294
/// @brief Version information structure for runtime queries

0 commit comments

Comments
 (0)