Skip to content

Does param_comparator (of signatures.is_call_compatible_with) have the right default? #49

@thorwhalen

Description

@thorwhalen

The default is currently None, which is [then changed to is_param_compatible_with if None] [https://github.com/i2mint/i2/blob/7c4f70e3614e2bdda4093ebb7d27c345d86ba16d/i2/signatures.py#L4291].

Two things here:

  • Perhaps defining param_comparator=is_param_compatible_with in the definition is better? (One con: Signature less readable. Big pro: More explicit). This pattern shows up again in is_param_compatible_with arguments
  • Is this default might be exactly what we need for is_call_compatible_with (is it? see is_default_value_compatible_with for example) but is not strong enough for a default signature comparison, nor flexibility enough for the general signature comparison use cases.

Metadata

Metadata

Labels

questionFurther information is requested

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions