Fix Etherscan V2 transactions api

Author: rafaelekol

README.md

@@ -46,7 +46,7 @@ val evmKit = EthereumKit.getInstance(
     address,
     Chain.Ethereum,
     RpcSource.ethereumInfuraHttp("projectId", "projectSecret"),
-    TransactionSource.ethereumEtherscan("apiKey"),
+    TransactionSource.etherscanApi("apiKey"),
     "unique_wallet_id"
 )
 ```

app/src/main/java/io/horizontalsystems/ethereumkit/sample/Configuration.kt

@@ -13,8 +13,6 @@ object Configuration {
 
     const val ethereumRpc = "https://api-dev.blocksdecoded.com/v1/ethereum-rpc/mainnet"
     const val etherscanKey = "GKNHXT22ED7PRVCKZATFZQD1YI7FK9AAYE"
-    const val arbiscanApiKey = "Z43JN5434XVNA5D73UGPWKF26G5D9MGDPZ"
-    const val bscScanKey = "5ZGSHWYHZVA8XZHB8PF6UUTRNNB4KT43ZZ"
 
     val erc20Tokens: List<Erc20Token>
         get() {

app/src/main/java/io/horizontalsystems/ethereumkit/sample/modules/addresswatch/AddressWatchViewModel.kt

@@ -129,11 +129,11 @@ class AddressWatchViewModel : ViewModel() {
 
         when (Configuration.chain) {
             Chain.BinanceSmartChain -> {
-                transactionSource = TransactionSource.bscscan(listOf(Configuration.bscScanKey))
+                transactionSource = TransactionSource.etherscanApi(Configuration.etherscanKey.split(","))
                 rpcSource = RpcSource.binanceSmartChainHttp()
             }
             Chain.Ethereum -> {
-                transactionSource = TransactionSource.ethereumEtherscan(Configuration.etherscanKey.split(","))
+                transactionSource = TransactionSource.etherscanApi(Configuration.etherscanKey.split(","))
                 rpcSource = RpcSource.Http(listOf(URI(Configuration.ethereumRpc)), null)
             }
             else -> {

app/src/main/java/io/horizontalsystems/ethereumkit/sample/modules/main/MainViewModel.kt

@@ -193,17 +193,17 @@ class MainViewModel : ViewModel() {
     private fun createKit(): EthereumKit {
         when (Configuration.chain) {
             Chain.BinanceSmartChain -> {
-                transactionSource = TransactionSource.bscscan(listOf(Configuration.bscScanKey))
+                transactionSource = TransactionSource.etherscanApi(Configuration.etherscanKey.split(","))
                 rpcSource = RpcSource.binanceSmartChainHttp()
             }
 
             Chain.Ethereum -> {
-                transactionSource = TransactionSource.ethereumEtherscan(Configuration.etherscanKey.split(","))
+                transactionSource = TransactionSource.etherscanApi(Configuration.etherscanKey.split(","))
                 rpcSource = RpcSource.Http(listOf(URI(Configuration.ethereumRpc)), null)
             }
 
             Chain.ArbitrumOne -> {
-                transactionSource = TransactionSource.arbiscan(listOf(Configuration.arbiscanApiKey),)
+                transactionSource = TransactionSource.etherscanApi(Configuration.etherscanKey.split(","))
                 rpcSource = RpcSource.arbitrumOneRpcHttp()
             }
 

ethereumkit/src/main/java/io/horizontalsystems/ethereumkit/models/TransactionSource.kt

@@ -19,77 +19,10 @@ class TransactionSource(val name: String, val type: SourceType) {
             )
         }
 
-        fun ethereumEtherscan(apiKeys: List<String>): TransactionSource {
+        fun etherscanApi(apiKeys: List<String>): TransactionSource {
             return etherscan("api", null, apiKeys)
         }
 
-        fun goerliEtherscan(apiKeys: List<String>): TransactionSource {
-            return etherscan("api-goerli", "goerli", apiKeys)
-        }
-
-        fun bscscan(apiKeys: List<String>): TransactionSource {
-            return TransactionSource(
-                "bscscan.com",
-                SourceType.Etherscan("https://api.bscscan.com", "https://bscscan.com", apiKeys)
-            )
-        }
-
-        fun polygonscan(apiKeys: List<String>): TransactionSource {
-            return TransactionSource(
-                "polygonscan.com",
-                SourceType.Etherscan("https://api.polygonscan.com", "https://polygonscan.com", apiKeys)
-            )
-        }
-
-        fun optimisticEtherscan(apiKeys: List<String>): TransactionSource {
-            return TransactionSource(
-                "optimistic.etherscan.io",
-                SourceType.Etherscan("https://api-optimistic.etherscan.io", "https://optimistic.etherscan.io", apiKeys)
-            )
-        }
-
-        fun arbiscan(apiKeys: List<String>): TransactionSource {
-            return TransactionSource(
-                "arbiscan.io",
-                SourceType.Etherscan("https://api.arbiscan.io", "https://arbiscan.io", apiKeys)
-            )
-        }
-
-        fun snowtrace(apiKeys: List<String>): TransactionSource {
-            return TransactionSource(
-                "snowtrace.io",
-                SourceType.Etherscan("https://api.snowtrace.io", "https://snowtrace.io", apiKeys)
-            )
-        }
-
-        fun gnosis(apiKeys: List<String>): TransactionSource {
-            return TransactionSource(
-                "gnosisscan.io",
-                SourceType.Etherscan("https://api.gnosisscan.io", "https://gnosisscan.io", apiKeys)
-            )
-        }
-
-        fun fantom(apiKeys: List<String>): TransactionSource {
-            return TransactionSource(
-                "ftmscan.com",
-                SourceType.Etherscan("https://api.ftmscan.com", "https://ftmscan.com", apiKeys)
-            )
-        }
-
-        fun basescan(apiKeys: List<String>): TransactionSource {
-            return TransactionSource(
-                "basescan.org",
-                SourceType.Etherscan("https://api.basescan.org", "https://basescan.org", apiKeys)
-            )
-        }
-
-        fun eraZkSync(apiKeys: List<String>): TransactionSource {
-            return TransactionSource(
-                "era.zksync.network",
-                SourceType.Etherscan("https://api-era.zksync.network", "https://era.zksync.network", apiKeys)
-            )
-        }
-
     }
 
 }