Move system_bridge service registration to async_setup#171360
Closed
timmo001 wants to merge 2 commits into
Closed
Conversation
Register services at integration load so automations can be validated before a config entry is loaded. Use ServiceValidationError for invalid bridge device selection. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors the System Bridge integration to register services in async_setup instead of async_setup_entry, following Home Assistant best practices.
Changes:
- Added
async_setupfunction that registers all services once at integration setup time, removing the need forpylint: disable-next=home-assistant-service-registered-in-setup-entrycomments. - Changed
HomeAssistantErrortoServiceValidationErrorin thevalid_devicehelper, and removed unusedHomeAssistantErrorimport. - Fixed a docstring typo (
send_keypress→send_text) and cleaned up some comments.
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
Member
|
Oh lol, missed this one |
Member
Author
no worries the other did more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
#170751
Generated with cursor (see co-author). Changes look accurate
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: