The RB4 lanes modifier is really broken

[Aloquendiar]

Okay, let me explain why we're back here.
The current RB4 Lanes modifier only affects Expert, and I don't know why. The code seems to return the values, or maybe not correctly. Putting roll_interval_ms with letters in the beatmatcher, for example, (real_bass (0 0 s s)), keeps the rolls. Putting 0 0 disables them, but if you're in pro mode with the rb4 lane modifier, this will only make them visible in Expert, not Hard, according to what I've seen. I don't have proof regarding Standard, but I suspected this a while ago.

[SonicSBL]

I encountered the same thing a while ago with the keys part for Short and Sweet. In Pro mode, lanes don't appear on Hard, even though I set the trill marker velocity to 48. But 5L still has the lanes on Hard. The RB4 lane modifier had no effect on this, and last time I checked, it wasn't supposed to.

[Aloquendiar]

I may have just come up with a great solution so that it only affects the songs that actually got lanes via rb4

[Aloquendiar]

btw, thanks for commenting on this. I'm checking if this fixes hard.

[Aloquendiar]

@SonicSBL you can try 5c7c9c3?

[SonicSBL]

No change to hard PK on Short and Sweet. Any other songs I should test?

EDIT: It turns out that to make trills work on Hard PK, you need to author the trill markers on that track at a lower velocity. I'll open a PR to fix that both here and in rb3 plus.