fix: keep a table of pox tx counts (#2462)

* fix: optimize pox tx counts

* fix: use table in read query

Author: rafa-stacks

migrations/1771944104000_burn-block-pox-tx-counts.js

@@ -0,0 +1,23 @@
+/** @param { import("node-pg-migrate").MigrationBuilder } pgm */
+exports.up = pgm => {
+  pgm.createTable('burn_block_pox_tx_counts', {
+    recipient: {
+      type: 'text',
+      notNull: true,
+      primaryKey: true,
+    },
+    count: {
+      type: 'integer',
+      notNull: true,
+      default: 0,
+    },
+  });
+  pgm.sql(`
+    INSERT INTO burn_block_pox_tx_counts (recipient, count)
+    (SELECT recipient, COUNT(*) AS count FROM burn_block_pox_txs WHERE canonical = true GROUP BY recipient)
+  `);
+};
+
+exports.down = pgm => {
+  pgm.dropTable('burn_block_pox_tx_counts');
+};

src/datastore/pg-store-v2.ts

@@ -230,8 +230,23 @@ export class PgStoreV2 extends BasePgStoreModule {
             : sql`burn_block_height = ${args.block.height}`
         : sql`TRUE`;
       const recipientFilter = args.recipient ? sql`recipient = ${args.recipient}` : sql`TRUE`;
+      const countQuery =
+        args.recipient && !args.block
+          ? sql`
+            SELECT COALESCE(count, 0)::int AS count
+            FROM burn_block_pox_tx_counts
+            WHERE recipient = ${args.recipient}
+          `
+          : sql`
+            SELECT COUNT(*)::int AS count
+            FROM burn_block_pox_txs
+            WHERE ${blockFilter} AND ${recipientFilter}
+          `;
       const results = await sql<(DbBurnBlockPoxTx & { total: number })[]>`
-        SELECT *, COUNT(*) OVER()::int AS total
+        WITH total_count AS (
+          ${countQuery}
+        )
+        SELECT *, (SELECT count FROM total_count) AS total
         FROM burn_block_pox_txs
         WHERE ${blockFilter} AND ${recipientFilter}
         ORDER BY burn_block_height DESC, tx_id ASC

src/datastore/pg-write-store.ts

@@ -657,8 +657,20 @@ export class PgWriteStore extends PgStore {
   async updateBurnBlockPoxTxs(args: { burnBlockPoxTxs: DbBurnBlockPoxTx[] }): Promise<void> {
     if (args.burnBlockPoxTxs.length === 0) return;
     await this.sql`
-      INSERT INTO burn_block_pox_txs ${this.sql(args.burnBlockPoxTxs)}
-      ON CONFLICT ON CONSTRAINT burn_block_pox_txs_unique_idx DO NOTHING
+      WITH inserts AS (
+        INSERT INTO burn_block_pox_txs ${this.sql(args.burnBlockPoxTxs)}
+        ON CONFLICT ON CONSTRAINT burn_block_pox_txs_unique_idx DO NOTHING
+        RETURNING recipient, canonical
+      ),
+      count_deltas AS (
+        SELECT recipient, COUNT(*) AS count
+        FROM inserts
+        WHERE canonical = true
+        GROUP BY recipient
+      )
+      INSERT INTO burn_block_pox_tx_counts (recipient, count)
+      (SELECT recipient, count FROM count_deltas)
+      ON CONFLICT (recipient) DO UPDATE SET count = burn_block_pox_tx_counts.count + EXCLUDED.count
     `;
   }
 
@@ -3716,9 +3728,21 @@ export class PgWriteStore extends PgStore {
     });
     q.enqueue(async () => {
       await sql`
-        UPDATE burn_block_pox_txs
-        SET canonical = ${canonical}
-        WHERE burn_block_hash = ${burnBlockHash} AND canonical != ${canonical}
+        WITH updates AS (
+          UPDATE burn_block_pox_txs
+          SET canonical = ${canonical}
+          WHERE burn_block_hash = ${burnBlockHash} AND canonical != ${canonical}
+          RETURNING recipient
+        ),
+        count_deltas AS (
+          SELECT recipient, COUNT(*) AS count
+          FROM updates
+          GROUP BY recipient
+        )
+        UPDATE burn_block_pox_tx_counts AS pc
+        SET count = ${canonical ? sql`pc.count + cd.count` : sql`pc.count - cd.count`}
+        FROM count_deltas AS cd
+        WHERE pc.recipient = cd.recipient
       `;
     });