Retry empty JSON results in auto search

Author: highkay

src/googleaisearch2api/app.py

@@ -58,7 +58,11 @@
     google_block_has_ip_mismatch,
     parse_google_block_ips,
 )
-from .quality import assess_search_answer_quality, normalize_answer_for_prompt
+from .quality import (
+    answer_has_empty_json_results,
+    assess_search_answer_quality,
+    normalize_answer_for_prompt,
+)
 from .query_adapter import (
     build_prompt_from_query_request,
     build_query_response,
@@ -89,6 +93,19 @@ def _normalize_result_for_prompt(prompt: str, result: GoogleAiResult) -> GoogleA
     return result.model_copy(update={"answer_text": normalized_answer})
 
 
+def _auto_empty_json_result_error(
+    engine_label: str,
+    prompt: str,
+    result: GoogleAiResult,
+    config: ServiceConfig,
+) -> str | None:
+    if config.search_engine != "auto":
+        return None
+    if not answer_has_empty_json_results(prompt, result.answer_text):
+        return None
+    return f"{engine_label} returned empty JSON results in auto mode"
+
+
 class DuckAiCircuitBreaker:
     def __init__(self, cooldown_seconds: int) -> None:
         self._cooldown_seconds = max(cooldown_seconds, 0)
@@ -330,6 +347,23 @@ def _run_google_ai(
                     error_message=message,
                 )
                 raise HTTPException(status_code=status.HTTP_502_BAD_GATEWAY, detail=message)
+            empty_json_message = _auto_empty_json_result_error(
+                "Google",
+                prompt,
+                result,
+                config,
+            )
+            if empty_json_message is not None:
+                services.store.finish_request_error(
+                    request_id,
+                    empty_json_message,
+                    duration_ms,
+                    result=result,
+                )
+                raise HTTPException(
+                    status_code=status.HTTP_502_BAD_GATEWAY,
+                    detail=empty_json_message,
+                )
             services.store.finish_request_success(request_id, result, duration_ms)
             if selection is not None:
                 services.proxy_session_store.finish_request_success(
@@ -520,6 +554,23 @@ def _run_duck_ai(
                 result=result,
             )
             raise HTTPException(status_code=status.HTTP_502_BAD_GATEWAY, detail=message)
+        empty_json_message = _auto_empty_json_result_error(
+            "Duck.ai",
+            prompt,
+            result,
+            config,
+        )
+        if empty_json_message is not None:
+            services.store.finish_request_error(
+                request_id,
+                empty_json_message,
+                duration_ms,
+                result=result,
+            )
+            raise HTTPException(
+                status_code=status.HTTP_502_BAD_GATEWAY,
+                detail=empty_json_message,
+            )
         services.store.finish_request_success(request_id, result, duration_ms)
         services.duck_circuit.record_success()
         if selection is not None:

src/googleaisearch2api/quality.py

@@ -427,6 +427,17 @@ def _extract_json_results_payload(answer: str) -> tuple[dict[str, Any], str] | N
     return None
 
 
+def answer_has_empty_json_results(prompt: str, answer: str) -> bool:
+    prompt_text = _normalize(prompt)
+    if not _prompt_requests_json_results(prompt_text):
+        return False
+    parsed = _extract_json_results_payload(answer)
+    if parsed is None:
+        return False
+    payload, _ = parsed
+    return not payload["results"]
+
+
 def _is_usable_result_url(value: object) -> bool:
     raw_url = str(value or "").strip()
     if _url_has_artifacts(raw_url):

tests/test_app.py

@@ -416,6 +416,70 @@ def test_query_auto_falls_back_to_duck_when_google_list_answer_is_too_short(
     assert "too short for the requested list" in (recent[1].error_message or "")
 
 
+def test_query_auto_falls_back_to_duck_when_google_json_results_are_empty(
+    test_app,
+) -> None:
+    prompt = (
+        "只返回一个 JSON 对象，输出格式固定为 "
+        '{"results":[{"title":"","content":"","source":"","url":"","published_date":"YYYY-MM-DD"}]}。'
+        '若找不到足够直接相关的结果，返回 {"results": []}。'
+        "问题：PingAn 000001.SZ 最新公告 新闻 催化 风险 最多返回 5 条"
+    )
+    duck_answer = (
+        '{"results":[{"title":"平安银行公告","content":"平安银行发布公告。",'
+        '"source":"证券时报","url":"https://www.stcn.com/article/detail/1234567.html",'
+        '"published_date":"2026-05-27"}]}'
+    )
+    with TestClient(test_app) as client:
+        _set_search_engine(test_app, "auto")
+        google_pool = _install_fake_pool(test_app, answer_text='{"results": []}')
+        duck_pool = _install_fake_duck_pool(test_app, answer_text=duck_answer)
+        response = client.post(
+            "/query",
+            headers=_auth_headers(),
+            json={"model": "google-search", "query": prompt},
+        )
+        recent = test_app.state.services.store.list_recent_requests(limit=2)
+
+    assert response.status_code == 200
+    assert response.json()["answer"] == duck_answer
+    assert google_pool.prompts == [f"User request:\n{prompt}"]
+    assert duck_pool.prompts == [f"User request:\n{prompt}"]
+    assert [record.engine for record in recent] == ["duck", "google"]
+    assert [record.status for record in recent] == ["ok", "error"]
+    assert "empty JSON results" in (recent[1].error_message or "")
+
+
+def test_query_auto_rejects_when_both_engines_return_empty_json_results(
+    test_app,
+) -> None:
+    prompt = (
+        "只返回一个 JSON 对象，输出格式固定为 "
+        '{"results":[{"title":"","content":"","source":"","url":"","published_date":"YYYY-MM-DD"}]}。'
+        '若找不到足够直接相关的结果，返回 {"results": []}。'
+        "问题：PingAn 000001.SZ 最新公告 新闻 催化 风险 最多返回 5 条"
+    )
+    with TestClient(test_app) as client:
+        _set_search_engine(test_app, "auto")
+        google_pool = _install_fake_pool(test_app, answer_text='{"results": []}')
+        duck_pool = _install_fake_duck_pool(test_app, answer_text='{"results": []}')
+        response = client.post(
+            "/query",
+            headers=_auth_headers(),
+            json={"model": "google-search", "query": prompt},
+        )
+        recent = test_app.state.services.store.list_recent_requests(limit=2)
+
+    assert response.status_code == 502
+    assert "Both search engines failed" in response.json()["detail"]
+    assert "Google returned empty JSON results in auto mode" in response.json()["detail"]
+    assert "Duck.ai returned empty JSON results in auto mode" in response.json()["detail"]
+    assert google_pool.prompts == [f"User request:\n{prompt}"]
+    assert duck_pool.prompts == [f"User request:\n{prompt}"]
+    assert [record.engine for record in recent] == ["duck", "google"]
+    assert [record.status for record in recent] == ["error", "error"]
+
+
 def test_query_uses_active_sticky_proxy_session_when_enabled(test_app) -> None:
     with TestClient(test_app) as client:
         test_app.state.services.store.update_config(