I've been reviewing the new v2 workspace trust documentation and find the [editor.workspace-trust] configuration confusing.
The key level suggests we're configuring security levels. The current design mixes concepts:
level = "none" - What does "level none" mean?
level = "servers" - Describes what is allowed to run, not a security level. lsp-only or language-servers-only would be better, but still wrong in this context
level = "insecure" - Only this describes a security "level"
If the key described the effect What is auto-trusted in every workspace then servers makes sense, but insecure makes even less sense, and none could become nothing.
The better way to do it would be to have what the security level does as the value:
level = "block_all" # old: "none"
"allow-lsp-only" # old: "servers"
"allow-all" # old: "insecure"
As it stands it is all mixed up and is very confusing.
Also, Whether to surface the modal popup is a very strange turn of phrase, maybe Whether to show the trust dialogue? I think the docs need a look over before the big release.
I've been reviewing the new v2 workspace trust documentation and find the
[editor.workspace-trust]configuration confusing.The key
levelsuggests we're configuring security levels. The current design mixes concepts:level = "none"- What does "level none" mean?level = "servers"- Describes what is allowed to run, not a security level.lsp-onlyorlanguage-servers-onlywould be better, but still wrong in this contextlevel = "insecure"- Only this describes a security "level"If the key described the effect
What is auto-trusted in every workspacethenserversmakes sense, butinsecuremakes even less sense, andnonecould becomenothing.The better way to do it would be to have what the security level does as the value:
As it stands it is all mixed up and is very confusing.
Also,
Whether to surface the modal popupis a very strange turn of phrase, maybeWhether to show the trust dialogue? I think the docs need a look over before the big release.