We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
2 parents ae549dc + 437bb7a commit 8ddb18cCopy full SHA for 8ddb18c
1 file changed
src/matminer/featurizers/structure/sites.py
@@ -93,7 +93,7 @@ def featurize(self, s):
93
vals = [[] for t in self._site_labels]
94
for i, site in enumerate(s.sites):
95
if (self.min_oxi is None or site.specie.oxi_state >= self.min_oxi) and (
96
- self.max_oxi is None or site.specie.oxi_state >= self.max_oxi
+ self.max_oxi is None or site.specie.oxi_state <= self.max_oxi
97
):
98
opvalstmp = self.site_featurizer.featurize(s, i)
99
for j, opval in enumerate(opvalstmp):
0 commit comments