Prune unused GUI and config code

gregorycarnegie · gregorycarnegie · commit 6f5f62a00dcc · 2026-06-27T18:22:59.000+01:00
diff --git a/ARCHITECTURE.md b/ARCHITECTURE.md
@@ -132,10 +132,6 @@ With `quality_rules.auto_select_best_face: true` (the GUI default), only the top
 - `nms_threshold: 0.2` (down from the YuNet upstream 0.3) — more aggressive overlap suppression absorbs IoU jitter for clearly-overlapping boxes.
 - `fcs-core::nms::dedup_close_centers` — post-NMS pass that drops detections whose centers are within 50% of the larger bbox's longest edge. Catches the multi-scale duplicates that low-IoU NMS lets through. Wired into `apply_postprocess`.
 
-#### Diagnostic logging
-
-There's a `log_detection_diag` helper in `fcs-gui/src/core/export.rs` (currently commented out) that logs per-image detection counts and sorted score lists at `debug` level. Uncomment its definition and call site in `run_batch_job`, then run two batches with `RUST_LOG="fcs_gui::core::export=debug"`, capture the `[batch-diag]` lines from each into a file, and diff with `compare_batch_diag.py` to see which images are flipping. Re-comment when done.
-
 ## Testing Matrix
 
 | Area                 | Location                               | Purpose                                         |
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/TODO.md b/TODO.md
@@ -60,7 +60,7 @@
 ### Coverage Follow-up #2 (fcs-utils gaps identified from coverage snapshot)
 
 - [x] `fcs-utils/src/color.rs` (80%) — cover 3-char/4-char/8-char hex parsing, `0x` prefix, `RgbaColor::to_hsv`/`from_hsv`, and blue-dominant HSV branch.
-- [x] `fcs-utils/src/config.rs` (75%) — cover `DetectionSettings::sanitize`, `InputDimensions::sanitize`, `CropSettings::sanitize`, `MetadataMode::from_str`, `ResizeQuality::from_str` error, `ResizeQuality::as_label`, `BatchLogFormat` Display, and `GpuSettings→GpuContextOptions` From impls.
+- [x] `fcs-utils/src/config.rs` (75%) — cover `DetectionSettings::sanitize`, `InputDimensions::sanitize`, `CropSettings::sanitize`, `MetadataMode::from_str`, `ResizeQuality::from_str` error, `ResizeQuality::as_label`, and `GpuSettings→GpuContextOptions` From impls.
 - [x] `fcs-utils/src/fixtures.rs` (58%) — cover `fixtures_dir()` via `YUNET_FIXTURE_ROOT` env var, `load_fixture_bytes`, and `load_fixture_json`.
 - [x] `fcs-utils/src/image_utils.rs` (75%) — cover `dynamic_to_bgr_chw`, `load_image` error path, and `resize_image` Triangle (non-fast) path.
 - [x] `fcs-utils/src/gpu/mod.rs` (49%) — cover `pack_rgba_pixels`/`unpack_rgba_pixels` roundtrip, all `GpuStatusIndicator` constructors, `GpuStatusMode::as_str`, `GpuAvailability::is_available`/`context`, and `GpuContextPool` acquire/try_acquire/capacity/available (GPU-gated).
diff --git a/config/gui_settings.json b/config/gui_settings.json
@@ -55,7 +55,6 @@
   },
   "enhance": {
     "enabled": true,
-    "preset": "none",
     "auto_color": false,
     "exposure_stops": 0.0,
     "brightness": 0,
@@ -70,14 +69,10 @@
     "enabled": true,
     "level": "trace"
   },
-  "batch_logging": {
-    "enabled": true,
-    "format": "json"
-  },
   "gpu": {
     "enabled": true,
     "respect_env": true,
     "inference": true,
     "preprocessing": true
   }
-}
+}
diff --git a/fcs-cli/Cargo.toml b/fcs-cli/Cargo.toml
@@ -16,12 +16,12 @@ log.workspace = true
 rayon.workspace = true
 serde.workspace = true
 serde_json.workspace = true
-tempfile.workspace = true
 walkdir.workspace = true
 
 [dev-dependencies]
 assert_cmd.workspace = true
 predicates.workspace = true
+tempfile.workspace = true
 
 [build-dependencies]
 winresource.workspace = true
diff --git a/fcs-cli/src/workflow.rs b/fcs-cli/src/workflow.rs
@@ -632,7 +632,6 @@ mod tests {
         let filter = QualityFilter {
             min_quality: None,
             auto_select: true,
-            fallback: None,
             auto_skip_no_high: false,
             suffix_enabled: false,
         };
@@ -785,7 +784,6 @@ mod tests {
         let filter = Arc::new(QualityFilter {
             min_quality: None,
             auto_select: false,
-            fallback: None,
             auto_skip_no_high: true,
             suffix_enabled: false,
         });
@@ -856,7 +854,6 @@ mod tests {
         let filter = Arc::new(QualityFilter {
             min_quality: Some(Quality::High),
             auto_select: false,
-            fallback: None,
             auto_skip_no_high: false,
             suffix_enabled: false,
         });
@@ -923,7 +920,6 @@ mod tests {
         let filter = Arc::new(QualityFilter {
             min_quality: None,
             auto_select: true,
-            fallback: None,
             auto_skip_no_high: false,
             suffix_enabled: false,
         });
diff --git a/fcs-gui/Cargo.toml b/fcs-gui/Cargo.toml
@@ -29,7 +29,6 @@ rayon.workspace = true
 rfd.workspace = true
 serde.workspace = true
 serde_json.workspace = true
-tempfile.workspace = true
 
 [dev-dependencies]
 sha2.workspace = true
diff --git a/fcs-gui/src/app.rs b/fcs-gui/src/app.rs
@@ -177,7 +177,6 @@ impl App2 {
             current_job: None,
             model_path_input,
             model_path_dirty: false,
-            clipboard_temp_images: Vec::new(),
             clipboard_paste_pending: false,
             suppress_image_paste: false,
             webcam_state: WebcamState::default(),
diff --git a/fcs-gui/src/core/cache.rs b/fcs-gui/src/core/cache.rs
diff --git a/fcs-gui/src/core/export.rs b/fcs-gui/src/core/export.rs
@@ -342,59 +342,6 @@ pub fn start_batch_export(app: &mut App2) {
     });
 }
 
-// Per-image detection diagnostic — commented out for normal use. Uncomment
-// this function and the call site in `run_batch_job` to capture per-image
-// detection counts and sorted score lists at `debug` level for diffing two
-// batch runs. See ARCHITECTURE.md "GPU Inference Determinism" for usage.
-//
-// Output lines are prefixed `[batch-diag]` for easy grepping; format:
-//   `[batch-diag] det=<n> border=<n> min=<f.4> max=<f.4> path=<...> scores=[<f.4>,...]`
-//
-// `compare_batch_diag.py` in the repo root parses two such files and reports
-// per-image mismatches.
-//
-// fn log_detection_diag(path: &Path, detections: &[Detection], score_threshold: f32) {
-//     if !log::log_enabled!(log::Level::Debug) {
-//         return;
-//     }
-//
-//     const BORDERLINE_MARGIN: f32 = 0.02;
-//     let borderline = detections
-//         .iter()
-//         .filter(|d| d.score < score_threshold + BORDERLINE_MARGIN)
-//         .count();
-//
-//     let (min_score, max_score) = detections.iter().fold((f32::MAX, f32::MIN), |(lo, hi), d| {
-//         (lo.min(d.score), hi.max(d.score))
-//     });
-//
-//     // Sort scores descending so cross-run diffs line up by rank rather than by
-//     // detection order (which can shuffle even without count change).
-//     let mut sorted_scores: Vec<f32> = detections.iter().map(|d| d.score).collect();
-//     sorted_scores.sort_by(|a, b| b.partial_cmp(a).unwrap_or(Ordering::Equal));
-//     let scores_str = sorted_scores
-//         .iter()
-//         .map(|s| format!("{:.4}", s))
-//         .collect::<Vec<_>>()
-//         .join(",");
-//
-//     let (min_display, max_display) = if detections.is_empty() {
-//         ("-".to_string(), "-".to_string())
-//     } else {
-//         (format!("{:.4}", min_score), format!("{:.4}", max_score))
-//     };
-//
-//     debug!(
-//         "[batch-diag] det={} border={} min={} max={} path={} scores=[{}]",
-//         detections.len(),
-//         borderline,
-//         min_display,
-//         max_display,
-//         path.display(),
-//         scores_str
-//     );
-// }
-
 /// Run one batch job and convert any panic into a [`BatchFileStatus::Failed`].
 /// One corrupt/edge-case image must not abort the rest of the batch.
 fn run_batch_job_panic_safe(
@@ -482,11 +429,6 @@ fn run_batch_job(
         }
     };
 
-    // Per-batch detection diagnostic — disabled. Re-enable by uncommenting this
-    // line and the `log_detection_diag` function below to investigate GPU inference
-    // run-to-run variance. See ARCHITECTURE.md "GPU Inference Determinism".
-    // log_detection_diag(&path, &detections, settings.detection.score_threshold);
-
     let faces_detected = detections.len();
     if detections.is_empty() {
         return BatchFileStatus::Completed {
diff --git a/fcs-gui/src/core/mod.rs b/fcs-gui/src/core/mod.rs
@@ -1,4 +1,3 @@
-pub mod cache;
 pub mod detection;
 pub mod export;
 pub mod quality;
diff --git a/fcs-gui/src/core/quality.rs b/fcs-gui/src/core/quality.rs
@@ -2,41 +2,8 @@
 
 use crate::types::DetectionWithQuality;
 use fcs_core::{CropSettings, Detection, crop_face_from_image};
-use fcs_utils::{config::AppSettings, quality::Quality};
+use fcs_utils::config::AppSettings;
 use image::DynamicImage;
-use std::collections::HashSet;
-
-pub fn apply_quality_rules_to_preview(
-    detections: &[DetectionWithQuality],
-    selected: &mut HashSet<usize>,
-    auto_skip_no_high_quality: bool,
-    auto_select_best: bool,
-) {
-    if detections.is_empty() {
-        return;
-    }
-
-    if auto_select_best {
-        let best = detections
-            .iter()
-            .enumerate()
-            .max_by(|(_, a), (_, b)| a.quality_score.partial_cmp(&b.quality_score).unwrap())
-            .map(|(i, _)| i);
-        if let Some(idx) = best {
-            selected.clear();
-            selected.insert(idx);
-        }
-    }
-
-    if auto_skip_no_high_quality {
-        let has_high = detections
-            .iter()
-            .any(|d| matches!(d.quality, Quality::High));
-        if !has_high {
-            selected.clear();
-        }
-    }
-}
 
 pub fn refresh_thumbnail(
     ctx: &egui::Context,
diff --git a/fcs-gui/src/interaction/coords.rs b/fcs-gui/src/interaction/coords.rs
diff --git a/fcs-gui/src/interaction/mod.rs b/fcs-gui/src/interaction/mod.rs
@@ -1,2 +1 @@
 pub mod bbox_drag;
-pub mod coords;
diff --git a/fcs-gui/src/types.rs b/fcs-gui/src/types.rs
@@ -19,7 +19,6 @@ use std::{
     path::PathBuf,
     sync::{Arc, atomic::AtomicBool, mpsc},
 };
-use tempfile::TempPath;
 
 // ── Sidebar / inspector tab selectors ────────────────────────────────────────
 
@@ -656,7 +655,6 @@ pub struct App2 {
     pub current_job: Option<u64>,
     pub model_path_input: String,
     pub model_path_dirty: bool,
-    pub clipboard_temp_images: Vec<TempPath>,
     pub clipboard_paste_pending: bool,
     /// Set when egui handled a text paste (clipboard had text). Cleared on the
     /// next V-release so we don't also trigger an image paste in that case.
diff --git a/fcs-gui/src/ui/inspector.rs b/fcs-gui/src/ui/inspector.rs
@@ -623,18 +623,6 @@ fn output_tab(ui: &mut Ui, app: &mut App2) {
         let mut q = app.settings.crop.jpeg_quality as f32;
         slider_with_label(ui, "", &mut q, 50.0, 100.0, "px");
         app.settings.crop.jpeg_quality = q as u8;
-
-        ui.add_space(8.0);
-        field_label(ui, "Output directory");
-        let mut dir_str = String::new(); // output_dir not in AppSettings; use rfd directly
-        ui.add(egui::TextEdit::singleline(&mut dir_str).desired_width(ui.available_width()));
-
-        ui.add_space(4.0);
-        if ui.button("Browse…").clicked()
-            && let Some(_dir) = rfd::FileDialog::new().pick_folder()
-        {
-            // would persist to settings if field exists
-        }
     });
 }
 
diff --git a/fcs-gui/src/ui/menubar.rs b/fcs-gui/src/ui/menubar.rs
@@ -6,7 +6,7 @@ use crate::theme::P;
 use crate::types::App2;
 use egui::{Frame, Popup, RichText, Sense, Ui, Vec2};
 use fcs_utils::{
-    config::{BatchLogFormat, MetadataMode, ResizeQuality},
+    config::{MetadataMode, ResizeQuality},
     configure_telemetry,
 };
 
@@ -227,27 +227,6 @@ pub fn show(ui: &mut Ui, app: &mut App2) {
                         );
                     }
 
-                    // ── Batch Logging ──────────────────────────────────────────
-                    ui.separator();
-                    section_label(ui, "Batch Logging");
-                    ui.checkbox(
-                        &mut app.settings.batch_logging.enabled,
-                        "Enable batch logging",
-                    );
-                    ui.horizontal(|ui| {
-                        ui.label("Format");
-                        ui.radio_value(
-                            &mut app.settings.batch_logging.format,
-                            BatchLogFormat::Json,
-                            "JSON",
-                        );
-                        ui.radio_value(
-                            &mut app.settings.batch_logging.format,
-                            BatchLogFormat::Csv,
-                            "CSV",
-                        );
-                    });
-
                     // ── Quality Rules ──────────────────────────────────────────
                     ui.separator();
                     section_label(ui, "Quality Rules");
diff --git a/fcs-gui/src/ui/widgets.rs b/fcs-gui/src/ui/widgets.rs
diff --git a/fcs-utils/src/config.rs b/fcs-utils/src/config.rs
diff --git a/fcs-utils/src/quality.rs b/fcs-utils/src/quality.rs
