Collapse all Nodes now resulting in tree getting cluttered with grandchild nodes

[Gitoffthelawn]

Version, Operating system
CT 1.7.0, Windows 11

Describe the bug
I may be mistaken, but with the introduction of the change made for #2814, I think the behaviour for Node Status at Startup -> Collapse all Nodes is now different, even though it shouldn't be. IIRC, before CT v1.7.0, if Collapse all Nodes was enabled in the preferences UI, all nodes and subnodes would be collapsed. Expanding a parent node would reveal all its child nodes, but not its grandchild nodes.

As of CT v1.7.0, when Collapse all Nodes is enabled, expanding a node not only expands the node to reveal all the child nodes, but also all the nodes of all its children, thus revealing all the grandchild nodes. This often makes it hard for the user to find the child node they seek.

To Reproduce
Steps to reproduce the behavior:

1. Enable to Preferences -> Tree Explorer -> Node Status at Startup -> Collapse all Nodes
2. Exit CT
3. Open CT
4. Click on any node in the tree that has children and grandchildren.
5. Notice that not only are the child nodes displayed, but also the grandchild nodes.

[jonathonmckay]

I have noticed this as well.

Personally, I find when I have too many nodes and sub nodes and sub sub sub .... nodes open, the clutter makes it difficult to find what I'm looking for (or even think straight). Often, I would use the "Collapse All Nodes" function (So much I pinned it on the tool bar) to "reset" the tree and start fresh.
However since 1.7.0, while it still collapses the top level nodes, if I open one again, it re-opens everything that was open, which is what I was trying to reset away from.
I understand the reason behind #2814 and that it could be what is needed by some people, but for me personally it doesn't allow me to "reset".

I propose that the behavior in #2814 be made an option, and/or ensure that when opening a CT notebook (respecting the option that's already there for this) or while using "Collapse All Nodes" that the tree ensures that all nodes are fully collapsed.

[giuspen]

About collapse all nodes at startup, that option should certainly not have changed, I shall have a look.
About the desire that at collapse you lose the expansion status of all descendants, opposite of request from #2814 I can make that optional but I wonder if a better solution would be to add an action to deep collapse as opposed to shallow collapse, what do you think?

[Gitoffthelawn]

About collapse all nodes at startup, that option should certainly not have changed, I shall have a look.

Thank you!

About the desire that at collapse you lose the expansion status of all descendants, opposite of request from #2814 I can make that optional but I wonder if a better solution would be to add an action to deep collapse as opposed to shallow collapse, what do you think?

I think that's a good idea, but I'll defer to @jonathonmckay as they brought up that particular issue.

[jonathonmckay]

... but I wonder if a better solution would be to add an action to deep collapse as opposed to shallow collapse, what do you think?

If by "deep collapse" you mean "recursively collapse all sub nodes at all levels" then I think this would suit my needs fine. Extra excellent if I can add it to the toolbar.