From 08c455b6add2f395a542b7505d70b8a31afc41d2 Mon Sep 17 00:00:00 2001 From: Josh Johanning Date: Tue, 3 Mar 2026 11:19:18 -0600 Subject: [PATCH 1/2] fix(commands): remove IsHidden property from UseGithubStorage option --- src/bbs2gh/Commands/GenerateScript/GenerateScriptCommand.cs | 1 - src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs | 3 +-- src/gei/Commands/GenerateScript/GenerateScriptCommand.cs | 1 - src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/bbs2gh/Commands/GenerateScript/GenerateScriptCommand.cs b/src/bbs2gh/Commands/GenerateScript/GenerateScriptCommand.cs index d3af5da54..49ea42746 100644 --- a/src/bbs2gh/Commands/GenerateScript/GenerateScriptCommand.cs +++ b/src/bbs2gh/Commands/GenerateScript/GenerateScriptCommand.cs @@ -127,7 +127,6 @@ public GenerateScriptCommand() : base( public Option UseGithubStorage { get; } = new("--use-github-storage") { - IsHidden = true, Description = "Enables multipart uploads to a GitHub owned storage for use during migration. " + "Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB).", }; diff --git a/src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs b/src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs index c93b5eaa9..5536e3a28 100644 --- a/src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs +++ b/src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs @@ -202,8 +202,7 @@ public MigrateRepoCommand() : base( public Option UseGithubStorage { get; } = new( name: "--use-github-storage", description: "Enables multipart uploads to a GitHub owned storage for use during migration. " + - "Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB).") - { IsHidden = true }; + "Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB)."); public override MigrateRepoCommandHandler BuildHandler(MigrateRepoCommandArgs args, IServiceProvider sp) { diff --git a/src/gei/Commands/GenerateScript/GenerateScriptCommand.cs b/src/gei/Commands/GenerateScript/GenerateScriptCommand.cs index d0e273948..ed884609b 100644 --- a/src/gei/Commands/GenerateScript/GenerateScriptCommand.cs +++ b/src/gei/Commands/GenerateScript/GenerateScriptCommand.cs @@ -107,7 +107,6 @@ public GenerateScriptCommand() : base( { IsHidden = true }; public Option UseGithubStorage { get; } = new("--use-github-storage") { - IsHidden = true, Description = "Enables multipart uploads to a GitHub owned storage for use during migration. " + "Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB).", }; diff --git a/src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs b/src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs index 409dce2d5..14e2bbcab 100644 --- a/src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs +++ b/src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs @@ -108,7 +108,6 @@ public MigrateRepoCommand() : base( }; public Option UseGithubStorage { get; } = new("--use-github-storage") { - IsHidden = true, Description = "Enables multipart uploads to a GitHub owned storage for use during migration. " + "Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB).", }; From 06be10c208417dceee9cd79c4d03e7e1e51be538 Mon Sep 17 00:00:00 2001 From: Josh Johanning Date: Tue, 3 Mar 2026 12:24:21 -0600 Subject: [PATCH 2/2] test: update use-github-storage option verification to remove hidden flag --- .../Commands/GenerateScript/GenerateScriptCommandTests.cs | 2 +- .../bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs | 2 +- .../gei/Commands/GenerateScript/GenerateScriptCommandTests.cs | 2 +- .../gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/OctoshiftCLI.Tests/bbs2gh/Commands/GenerateScript/GenerateScriptCommandTests.cs b/src/OctoshiftCLI.Tests/bbs2gh/Commands/GenerateScript/GenerateScriptCommandTests.cs index 236e292cd..f8c591432 100644 --- a/src/OctoshiftCLI.Tests/bbs2gh/Commands/GenerateScript/GenerateScriptCommandTests.cs +++ b/src/OctoshiftCLI.Tests/bbs2gh/Commands/GenerateScript/GenerateScriptCommandTests.cs @@ -58,7 +58,7 @@ public void Should_Have_Options() TestHelpers.VerifyCommandOption(_command.Options, "keep-archive", false); TestHelpers.VerifyCommandOption(_command.Options, "no-ssl-verify", false); TestHelpers.VerifyCommandOption(_command.Options, "target-api-url", false); - TestHelpers.VerifyCommandOption(_command.Options, "use-github-storage", false, true); + TestHelpers.VerifyCommandOption(_command.Options, "use-github-storage", false); } [Fact] diff --git a/src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs b/src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs index 625130223..aceea4410 100644 --- a/src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs +++ b/src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs @@ -91,7 +91,7 @@ public void Should_Have_Options() TestHelpers.VerifyCommandOption(command.Options, "no-ssl-verify", false); TestHelpers.VerifyCommandOption(command.Options, "target-api-url", false); TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false, true); - TestHelpers.VerifyCommandOption(command.Options, "use-github-storage", false, true); + TestHelpers.VerifyCommandOption(command.Options, "use-github-storage", false); } [Fact] diff --git a/src/OctoshiftCLI.Tests/gei/Commands/GenerateScript/GenerateScriptCommandTests.cs b/src/OctoshiftCLI.Tests/gei/Commands/GenerateScript/GenerateScriptCommandTests.cs index b2eb3f2d9..199893cc8 100644 --- a/src/OctoshiftCLI.Tests/gei/Commands/GenerateScript/GenerateScriptCommandTests.cs +++ b/src/OctoshiftCLI.Tests/gei/Commands/GenerateScript/GenerateScriptCommandTests.cs @@ -57,7 +57,7 @@ public void Should_Have_Options() TestHelpers.VerifyCommandOption(command.Options, "keep-archive", false); TestHelpers.VerifyCommandOption(command.Options, "target-api-url", false); TestHelpers.VerifyCommandOption(command.Options, "target-uploads-url", false, true); - TestHelpers.VerifyCommandOption(command.Options, "use-github-storage", false, true); + TestHelpers.VerifyCommandOption(command.Options, "use-github-storage", false); } [Fact] diff --git a/src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs b/src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs index 26d039592..e39f73f8e 100644 --- a/src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs +++ b/src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs @@ -40,7 +40,7 @@ public void Should_Have_Options() TestHelpers.VerifyCommandOption(command.Options, "github-target-pat", false); TestHelpers.VerifyCommandOption(command.Options, "verbose", false); TestHelpers.VerifyCommandOption(command.Options, "keep-archive", false); - TestHelpers.VerifyCommandOption(command.Options, "use-github-storage", false, true); + TestHelpers.VerifyCommandOption(command.Options, "use-github-storage", false); } } }