Skip to content
This repository was archived by the owner on Dec 30, 2025. It is now read-only.

Should GeoServerRESTStoreManager.remove throw a MalformedURLException? #219

Description

@NielsCharlier

https://github.com/geosolutions-it/geoserver-manager/blob/master/src/main/java/it/geosolutions/geoserver/rest/manager/GeoServerRESTStoreManager.java#L103

  • It is inconsistent because none of the other methods throw this exception (create, update), even though they take the same parameters
  • Not really sure why the method changes the url string to URL and back to String ? No other method does this. Is that by accident or for a reason?
  • In any case, even if there is a reason, I think the exception treatment should be internalised. The URL is provided by the user at the creation of the restmanager and will then be verified anyways

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions