Forge egg confusion

[red-daut]

Am I missing something… the egg is named forge but uses paper (but not forge?), and it seems it doesn't support the forge_version variable.

Additionally, the egg that's named paper seems to be for paper. So why is there seemingly 2 paper eggs and no forge egg? Is there some type of mix up here?

From my searching on this repo, the MSH repo and the Discord server I haven't been able to put together all that much. But here are some assumptions:

• Versions of forge older than 1.17 are not supported in the “forge” version of the egg. If this is true… why is this the case?
• The “forge” version of the egg doesn't support older java versions (such as java 8)
• Large modpacks aren't supported with MSH due to startup script differences. It does seem, though, some have been successful with some tweaking
• Large modpacks that take longer than 60 seconds to load will cause MSH to timeout. Why not allow this to be a configurable value? I see that initially it was set to 10 seconds and then later set to 60 for this exact reason.

What I am trying to accomplish is within Pterodactyl have a hibernated RLcraft instance. RLcraft uses Minecraft 1.12.2 and forge version 1.12.2-14.23.5.2860 and uses java 8.

Is this possible with an egg in Pterodactyl and MSH?

I was considering trying to patch together a new egg that would use MSH to meet the requirements for RLcraft in Pterodactyl. Is there anything that would be a showstopper?

Either way, I love MSH, thanks for making it. Looking forward to hearing from you on this use case.

[BolverBlitz]

Am I missing something… the egg is named forge but uses paper (but not forge?), and it seems it doesn't support the forge_version variable.

I see you refer to "Build Number" variable in the forge egg, yeah i forgot to remove that. Its not used. It could be replaced by "forge_version" if anyone needs to set a specific build.

Additionally, the egg that's named paper seems to be for paper. So why is there seemingly 2 paper eggs and no forge egg? Is there some type of mix up here?

There was a mixup a long time ago, wich lead to the variable mixup from above.

Versions of forge older than 1.17 are not supported in the “forge” version of the egg. If this is true… why is this the case?

When i originaly made the egg, forge and paper hat the same install process with server.jar - When they added the arguments.txt in 1.17 or so i just copyed the pterodactyl forge egg that most likly at the time didn´t support older versions. However the new forge egg from pterodactyl supports all forge variables.

The “forge” version of the egg doesn't support older java versions (such as java 8)

Minecraft 1.17 and above don´t need newer JAVA, i removed that to reduce confution at the time.

Large modpacks aren't supported with MSH due to startup script differences. It does seem, though, some have been successful with some tweaking

They are, to a degree. Some versions of minecraft and mod combinations do work well with MSH, i have a old 1.8.9 pack and 1.12.2 pack running with over 400 mods each. But i simply didn´t test all cases and some cases need diffrent fixes. (Like hybernation plugin, removal of some mod that just hangs) However, this only applys to the actual hibernation. MSH start/stop should work on all of them. (Not tested though) - SuspendAllow = false

Large modpacks that take longer than 60 seconds to load will cause MSH to timeout. Why not allow this to be a configurable value? I see that initially it was set to 10 seconds and then later set to 60 for this exact reason.

You actualy can set the time higher than 60 seconds. Look at variable "Wait time for shutdown" and "TimeToKill", why is this at whatever it is? Well it starts all servers on my server just fine.

What I am trying to accomplish is within Pterodactyl have a hibernated RLcraft instance. RLcraft uses Minecraft 1.12.2 and forge version 1.12.2-14.23.5.2860 and uses java 8.

Well all i can say is try it... There are too many factors to consider. Try tweeking the "SuspendRefresh" variable if you run into watchdog crashes. Maybe you find some mod that does the same as the hibernate plugin. (I used CatServer in the past and i worked, but many years ago)

I was considering trying to patch together a new egg that would use MSH to meet the requirements for RLcraft in Pterodactyl. Is there anything that would be a showstopper?

Well in the eggs here and pakervcp Eggs i guess.

[BolverBlitz]

I may, or may not try to make the forge egg support all versions. No promises thought, but its like a simple task in case i need some time away from coding in the near future.

[red-daut]

Thanks for the reply, you provided a lot of much-needed clarity.

In summary, it seems that the forge egg is outdated and a new updated forge egg is in order.

I'll attempt this and summit a PR if I am successful.

[Mazuna]

I rewrote the Forge ggg and made sure the FORGE_VERSION variable gets assigned correctly.
Check my PR for the improved egg.
#20