build an offline OBR for galasa uber

Signed-off-by: Stewart Francis <stewartfrancis@uk.ibm.com>

Author: stewartfrancis

modules/cli/pkg/cmd/runsCleanupLocal.go

@@ -100,9 +100,10 @@ func (cmd *RunsCleanupLocalCommand) createCobraCmd(
 		"the version of galasa you want to use. This should match the version of the galasa obr you built your resource cleanup providers against.")
 
 	runsCleanupLocalCobraCmd.Flags().StringSliceVar(&cmd.values.runsCleanupLocalCmdParams.RemoteMavenRepos, "remoteMaven",
-		[]string{"https://repo.maven.apache.org/maven2"},
+		[]string{},
 		"the urls of the remote maven repositories where galasa bundles can be loaded from. "+
-			"Defaults to maven central.")
+			"If not specified, no remote Maven repositories will be used and mvn: URIs in OBRs will fail to resolve. "+
+			"Multiple repositories can be specified by using this flag multiple times.")
 
 	runsCleanupLocalCobraCmd.Flags().StringVar(&cmd.values.runsCleanupLocalCmdParams.LocalMaven, "localMaven", "",
 		"The url of a local maven repository are where galasa bundles can be loaded from on your local file system. Defaults to your home .m2/repository file. Please note that this should be in a URL form e.g. 'file:///Users/myuserid/.m2/repository', or 'file://C:/Users/myuserid/.m2/repository'")

modules/cli/pkg/cmd/runsSubmitLocal.go

@@ -99,9 +99,9 @@ func (cmd *RunsSubmitLocalCommand) createRunsSubmitLocalCobraCmd(
 	//currentUserName := runs.GetCurrentSystemUserName()
 
 	runsSubmitLocalCobraCmd.Flags().StringVar(&cmd.values.runsSubmitLocalCmdParams.RemoteMaven, "remoteMaven",
-		"https://repo.maven.apache.org/maven2",
-		"the url of the remote maven where galasa bundles can be loaded from. "+
-			"Defaults to maven central.")
+		"",
+		"the url of the remote maven repository where galasa bundles can be loaded from. "+
+			"If not specified, no remote Maven repository will be used and mvn: URIs in OBRs will fail to resolve.")
 
 	runsSubmitLocalCobraCmd.Flags().StringVar(&cmd.values.runsSubmitLocalCmdParams.LocalMaven, "localMaven", "",
 		"The url of a local maven repository are where galasa bundles can be loaded from on your local file system. Defaults to your home .m2/repository file. Please note that this should be in a URL form e.g. 'file:///Users/myuserid/.m2/repository', or 'file://C:/Users/myuserid/.m2/repository'")

modules/cli/pkg/launcher/jvmLauncher.go

@@ -603,7 +603,6 @@ func (launcher *JvmLauncher) IsLocal() bool {
 // --remotemaven $REMOTE_MAVEN \
 // --bootstrap file:${HOME}/.galasa/bootstrap.properties \
 // --overrides file:${HOME}/.galasa/overrides.properties \
-// --obr mvn:dev.galasa/dev.galasa.uber.obr/${OBR_VERSION}/obr \
 // --obr mvn:${TEST_OBR_GROUP_ID}/${TEST_OBR_ARTIFACT_ID}/${TEST_OBR_VERSION}/obr \
 // --test ${TEST_BUNDLE}/${TEST_JAVA_CLASS} | tee jvm-log.txt | grep "[*][*][*]" | grep -v "[*][*][*][*]" | sed -e "s/[--]*//g"
 //
@@ -614,7 +613,6 @@ func (launcher *JvmLauncher) IsLocal() bool {
 //	    --remotemaven https://development.galasa.dev/main/maven-repo/obr/ \
 //	    --bootstrap file:/Users/mcobbett/.galasa/bootstrap.properties \
 //	    --overrides file:/Users/mcobbett/.galasa/overrides.properties \
-//	    --obr mvn:dev.galasa/dev.galasa.uber.obr/0.26.0/obr \
 //	    --obr mvn:dev.galasa.example.banking/dev.galasa.example.banking.obr/0.0.1-SNAPSHOT/obr \
 //	    --test dev.galasa.example.banking.payee/dev.galasa.example.banking.payee.TestPayee
 func getCommandSyntax(

modules/cli/pkg/launcher/jvmLauncherUtils.go

@@ -103,11 +103,6 @@ func getBaseCommandSyntax(
 			args = append(args, obrMvnPath)
 		}
 
-		// --obr mvn:dev.galasa/dev.galasa.uber.obr/${OBR_VERSION}/obr
-		args = append(args, "--obr")
-		galasaUberObrPath := "mvn:dev.galasa/dev.galasa.uber.obr/" + galasaVersionToRun + "/obr"
-		args = append(args, galasaUberObrPath)
-
 		if isTraceEnabled {
 			args = append(args, "--trace")
 		}

modules/cli/pkg/launcher/resourceCleanupJvmLauncher.go

@@ -192,7 +192,6 @@ func (launcher *ResourceCleanupJvmLauncher) RunResourceCleanup() error {
 // --localmaven file:${M2_PATH}/repository/ \
 // --remotemaven $REMOTE_MAVEN \
 // --bootstrap file:${HOME}/.galasa/bootstrap.properties \
-// --obr mvn:dev.galasa/dev.galasa.uber.obr/${OBR_VERSION}/obr \
 // --obr mvn:${OBR_GROUP_ID}/${OBR_ARTIFACT_ID}/${OBR_VERSION}/obr \
 // --includes-monitor-pattern "dev.galasa.*"
 // --excludes-monitor-pattern "*MyUnwantedCleanupJob"

modules/framework/galasa-parent/galasa-boot/src/main/java/dev/galasa/boot/Launcher.java

@@ -445,7 +445,7 @@ private void checkForRemoteMaven(CommandLine commandLine) {
                     this.remoteMavenRepos.add(new URL(option.replaceFirst("/*$", "")));
                 }
             }
-            this.remoteMavenRepos.add(new URL("https://repo.maven.apache.org/maven2"));
+            // No longer automatically adding Maven Central - users must explicitly opt-in via --remotemaven
         } catch (MalformedURLException e) {
             logger.error("invalid remote maven urls", e);
             commandLineError(null);

modules/gradle/build-locally.sh

@@ -208,7 +208,7 @@ function check_secrets {
 function build_gradle_plugin() {
     h1 "Building ${project}"
 
-    cmd="gradle --no-daemon \
+    cmd="./gradlew --no-daemon \
     ${CONSOLE_FLAG} \
     -Dorg.gradle.java.home=${JAVA_HOME} \
     -PsourceMaven=${SOURCE_MAVEN} ${OPTIONAL_DEBUG_FLAG} \