Skip to content

Commit 0a1c972

Browse files
committed
FAC: Comment out unused _to_attrdict methods in base, formula, and views modules
1 parent 3e7d2a6 commit 0a1c972

File tree

3 files changed

+29
-29
lines changed

3 files changed

+29
-29
lines changed

modelx/core/base.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -542,21 +542,21 @@ def _baseattrs(self):
542542

543543
return result
544544

545-
def _to_attrdict(self, attrs=None):
546-
"""Get extra attributes"""
547-
result = self._baseattrs
548-
549-
for name in attrs:
550-
if hasattr(self, name):
551-
attr = getattr(self, name)
552-
if hasattr(attr, "_to_attrdict"):
553-
result[name] = attr._to_attrdict(attrs)
554-
elif callable(attr):
555-
result[name] = attr()
556-
else:
557-
result[name] = attr
558-
559-
return result
545+
# def _to_attrdict(self, attrs=None):
546+
# """Get extra attributes"""
547+
# result = self._baseattrs
548+
#
549+
# for name in attrs:
550+
# if hasattr(self, name):
551+
# attr = getattr(self, name)
552+
# if hasattr(attr, "_to_attrdict"):
553+
# result[name] = attr._to_attrdict(attrs)
554+
# elif callable(attr):
555+
# result[name] = attr()
556+
# else:
557+
# result[name] = attr
558+
#
559+
# return result
560560

561561
def _get_attrdict(self, extattrs=None, recursive=True):
562562
"""Get attributes in a dict"""

modelx/core/formula.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,8 +428,8 @@ def _reload(self, module=None):
428428

429429
return self
430430

431-
def _to_attrdict(self, attrs=None):
432-
return {"source": self.source}
431+
# def _to_attrdict(self, attrs=None):
432+
# return {"source": self.source}
433433

434434
def _get_attrdict(self, extattrs=None, recursive=True):
435435
return {"source": self.source}

modelx/core/views.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -104,18 +104,18 @@ def _baseattrs_private(self):
104104

105105
return result
106106

107-
def _to_attrdict(self, attrs=None):
108-
"""Used by spyder-modelx"""
109-
110-
result = {"type": type(self).__name__}
111-
try:
112-
result["items"] = {
113-
name: item._to_attrdict(attrs) for name, item in self.items()
114-
}
115-
except:
116-
raise RuntimeError("%s literadict raised an error" % self)
117-
118-
return result
107+
# def _to_attrdict(self, attrs=None):
108+
# """Used by spyder-modelx"""
109+
#
110+
# result = {"type": type(self).__name__}
111+
# try:
112+
# result["items"] = {
113+
# name: item._to_attrdict(attrs) for name, item in self.items()
114+
# }
115+
# except:
116+
# raise RuntimeError("%s literadict raised an error" % self)
117+
#
118+
# return result
119119

120120
def _get_attrdict(self, extattrs=None, recursive=True):
121121
"""Get extra attributes"""

0 commit comments

Comments
 (0)