Skip to content

Remove divisor parameter from ExponentialCurve #33

Description

@coderabbitai

Description

Based on the discussion in PR #21, the divisor parameter in the ExponentialCurve class should be removed, and the implementation should revert to dividing by base instead.

Context

  • The divisor parameter was added to allow more control over the curve behavior
  • However, this implementation can cause mathematical inconsistencies as pointed out in the discussion
  • The current equation is: y = ((x/abs(x)) * ((1 + [base])^abs(x) -1)) / [divisor]
  • The original equation was: y = ((x/abs(x)) * ((1 + [base])^abs(x) -1)) / [base]

Suggested Changes

  1. Remove the divisor parameter from the ExponentialCurve class
  2. Revert to dividing by base in the implementation
  3. Update all usages of ExponentialCurve in the codebase to remove the second parameter

References

Requested by @Baconing

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions