Skip to content

Commit d6e3cc5

Browse files
authored
refactor(runtime): remove incomplete GetRuntimeStatus function implementation (#5792)
- Deleted the unfinished GetRuntimeStatus function which retrieved runtime status by type, name, and namespace - Cleaned up unused code and comments related to runtime status retrieval - Retained and organized existing RuntimeInfo interface and related helper functions for runtime info construction - Ensured the code only includes fully implemented and functional parts to improve maintainability Signed-off-by: cheyang <cheyang.cy@alibaba-inc.com>
1 parent 3e9654f commit d6e3cc5

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

pkg/ddc/base/runtime.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,16 +235,17 @@ func WithAnnotations(annotations map[string]string) RuntimeInfoOption {
235235
func (info *RuntimeInfo) GetAnnotations() map[string]string {
236236
return info.annotations
237237
}
238+
238239
// WithClientMetrics sets the client metrics for the RuntimeInfo.
239-
// This function returns a RuntimeInfoOption that configures how client metrics
240-
// are collected, including setting a default scrape target if none is provided
240+
// This function returns a RuntimeInfoOption that configures how client metrics
241+
// are collected, including setting a default scrape target if none is provided
241242
// and parsing the scrape target string into a valid selector.
242243
//
243244
// Parameters:
244-
// - clientMetrics (datav1alpha1.ClientMetrics): The client metrics configuration to be applied.
245+
// - clientMetrics (datav1alpha1.ClientMetrics): The client metrics configuration to be applied.
245246
//
246247
// Returns:
247-
// - (RuntimeInfoOption): A function that updates the RuntimeInfo with the specified metrics configuration.
248+
// - (RuntimeInfoOption): A function that updates the RuntimeInfo with the specified metrics configuration.
248249
func WithClientMetrics(clientMetrics datav1alpha1.ClientMetrics) RuntimeInfoOption {
249250
return func(info *RuntimeInfo) error {
250251
if len(clientMetrics.ScrapeTarget) == 0 {

0 commit comments

Comments
 (0)