Skip to content

Commit 2b550e9

Browse files
fix: watch Job resources in dataload and datamigrate controllers (#5675)
Signed-off-by: Monika Jakhar <jakharmonika364@gmail.com>
1 parent 50940f8 commit 2b550e9

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

pkg/controllers/v1alpha1/dataload/dataload_controller.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,15 @@ func (r *DataLoadReconciler) SetupWithManager(mgr ctrl.Manager, options controll
117117
return ctrl.NewControllerManagedBy(mgr).
118118
WithOptions(options).
119119
For(&datav1alpha1.DataLoad{}).
120+
Owns(&batchv1.Job{}).
120121
Owns(&batchv1.CronJob{}).
121122
Complete(r)
122123
} else {
123124
ctrl.Log.Info("batch/v1 cronjobs cannnot be found in cluster, fallback to watch batch/v1beta1 cronjobs for compatibility")
124125
return ctrl.NewControllerManagedBy(mgr).
125126
WithOptions(options).
126127
For(&datav1alpha1.DataLoad{}).
128+
Owns(&batchv1.Job{}).
127129
Owns(&batchv1beta1.CronJob{}).
128130
Complete(r)
129131
}

pkg/controllers/v1alpha1/datamigrate/datamigrate_controller.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,13 +115,15 @@ func (r *DataMigrateReconciler) SetupWithManager(mgr ctrl.Manager, options contr
115115
return ctrl.NewControllerManagedBy(mgr).
116116
WithOptions(options).
117117
For(&datav1alpha1.DataMigrate{}).
118+
Owns(&batchv1.Job{}).
118119
Owns(&batchv1.CronJob{}).
119120
Complete(r)
120121
} else {
121122
ctrl.Log.Info("batch/v1 cronjobs cannot be found in cluster, fallback to watch batch/v1beta1 cronjobs for compatibility")
122123
return ctrl.NewControllerManagedBy(mgr).
123124
WithOptions(options).
124125
For(&datav1alpha1.DataMigrate{}).
126+
Owns(&batchv1.Job{}).
125127
Owns(&batchv1beta1.CronJob{}).
126128
Complete(r)
127129
}

0 commit comments

Comments
 (0)