Concurrent creation of two users fails, while FLOW_WALLET_ADMIN_PROPOSAL_KEY_COUNT is set

[uhbif19]

If more than one user is created, all but one transaction fails.

[uhbif19]

Admin account actually has 30 keys:

https://flow-view-source.com/testnet/account/0xeac6eb45fad808df

But wallet api produces error:

[JOBS] 2021/12/14 18:24:10 workerpool.go:239: WARNING: Job(id: "968d5bb6-df22-4444-b8d0-1a2fdea8453a", type: "account_create") execution resulted with error: [Error Code: 1007] invalid proposal key: public key 0 on account eac6eb45fad808df ...

This bug is on both mainnet and testnet.

[latenssi]

Thank you @uhbif19 for posting this! We will look into it.

[uhbif19]

UPD It works okay on mainnet with 0.7 version, but gives error on testnet 0.8 version.

[latenssi]

@uhbif19 I am unable reproduce this. Do you have FLOW_WALLET_ADMIN_PROPOSAL_KEY_COUNT set to 30? (it is not well documented yet so I understand if you don't have it set)

Here is a PR testing this: #236

[uhbif19]

@latenssi Yes it is set to 30.

[latenssi]

@uhbif19 Ok, thanks! Are you running multiple instances of the wallet service with the same settings?

I assume you are not using the sync way of calling the API when creating the accounts (as the error log had a job id in it)?

[seitau]

I've encountered the same error with v0.8.0 but not in the latest main branch.

[uhbif19]

@latenssi

We using one instance per one depolyment and not using sync.

[latenssi]

@uhbif19 Couple of important questions I should have asked first: is this happening every time you try to create multiple accounts and how are you creating multiple accounts concurrently?

[uhbif19]

@uhbif19 Looks like it happens every time. We POSTing /accounts to create account.

[latenssi]

@uhbif19 Do the accounts eventually get created? The wallet should retry failed attempts (max 10 retries).

[uhbif19]

@latenssi How does this work? We do not cover retrying in our code.

[uhbif19]

@latenssi Is there any way to disable retrying.