From a52c859a613ffaabce7977cec0beb4b597b9a623 Mon Sep 17 00:00:00 2001 From: Luke Heath Date: Fri, 8 May 2026 16:22:38 -0500 Subject: [PATCH 1/3] Style fixes: label form button order, empty-state spacing, registration dark mode Resolves #44923 --- changes/44923-style-fixes | 3 +++ .../ConfirmationPage/_styles.scss | 4 ++++ .../forms/fields/InputField/_styles.scss | 6 ----- .../RegistrationPage/Breadcrumbs/_styles.scss | 24 ------------------- .../labels/components/LabelForm/LabelForm.tsx | 6 ++--- .../PoliciesTable/PoliciesTable.tsx | 1 + .../components/QueriesTable/QueriesTable.tsx | 1 + 7 files changed, 12 insertions(+), 33 deletions(-) create mode 100644 changes/44923-style-fixes diff --git a/changes/44923-style-fixes b/changes/44923-style-fixes new file mode 100644 index 00000000000..5a1f6d2cb3c --- /dev/null +++ b/changes/44923-style-fixes @@ -0,0 +1,3 @@ +* Moved the "Save" button to the left of "Cancel" on the Add/edit label page. +* Removed the empty filter row above the empty state on the Reports and Policies pages so the empty state sits closer to the page header. +* Cleaned up dark-mode styling on the initial Fleet setup page (active breadcrumb, input field hover/active borders, and confirmation table row backgrounds). diff --git a/frontend/components/forms/RegistrationForm/ConfirmationPage/_styles.scss b/frontend/components/forms/RegistrationForm/ConfirmationPage/_styles.scss index 1bbe423bfef..126091a1ea8 100644 --- a/frontend/components/forms/RegistrationForm/ConfirmationPage/_styles.scss +++ b/frontend/components/forms/RegistrationForm/ConfirmationPage/_styles.scss @@ -100,3 +100,7 @@ } } } + +body.dark-mode .confirm-user-reg__table tbody tr { + background-color: transparent; +} diff --git a/frontend/components/forms/fields/InputField/_styles.scss b/frontend/components/forms/fields/InputField/_styles.scss index 1b649c834cb..dd2e3060b8b 100644 --- a/frontend/components/forms/fields/InputField/_styles.scss +++ b/frontend/components/forms/fields/InputField/_styles.scss @@ -16,12 +16,6 @@ color: $ui-fleet-black-50; } - &:hover:not(.input-field--read-only) { - box-shadow: none; - border: 1px solid $ui-fleet-black-75-over; - } - - &:active:not(.input-field--read-only), &:focus:not(.input-field--read-only), &:focus-visible:not(.input-field--read-only) { box-shadow: none; diff --git a/frontend/pages/RegistrationPage/Breadcrumbs/_styles.scss b/frontend/pages/RegistrationPage/Breadcrumbs/_styles.scss index 357ac0ac4c0..8088f81cc96 100644 --- a/frontend/pages/RegistrationPage/Breadcrumbs/_styles.scss +++ b/frontend/pages/RegistrationPage/Breadcrumbs/_styles.scss @@ -65,14 +65,6 @@ } &.registration-breadcrumbs__page--active { - &::before { - background: linear-gradient( - to right, - $ui-fleet-black-75 50%, - $ui-fleet-black-25 50% - ); - } - &::after { background-color: transparent; outline: 2px solid $ui-fleet-black-75; @@ -101,14 +93,6 @@ } &.registration-breadcrumbs__page--active { - &::before { - background: linear-gradient( - to right, - $ui-fleet-black-75 50%, - $ui-fleet-black-25 50% - ); - } - &::after { background-color: transparent; outline: 2px solid $ui-fleet-black-75; @@ -140,14 +124,6 @@ } &.registration-breadcrumbs__page--active { - &::before { - background: linear-gradient( - to right, - $ui-fleet-black-75 50%, - $ui-fleet-black-25 50% - ); - } - &::after { background-color: transparent; outline: 2px solid $ui-fleet-black-75; diff --git a/frontend/pages/labels/components/LabelForm/LabelForm.tsx b/frontend/pages/labels/components/LabelForm/LabelForm.tsx index 5cdd0b6aa0c..cc5efea3e90 100644 --- a/frontend/pages/labels/components/LabelForm/LabelForm.tsx +++ b/frontend/pages/labels/components/LabelForm/LabelForm.tsx @@ -171,9 +171,6 @@ const LabelForm = ({ {teamName ? : null} {additionalFields}
- ( @@ -186,6 +183,9 @@ const LabelForm = ({ )} /> +
); diff --git a/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/PoliciesTable.tsx b/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/PoliciesTable.tsx index e1972c78fe1..41194226c46 100644 --- a/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/PoliciesTable.tsx +++ b/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/PoliciesTable.tsx @@ -155,6 +155,7 @@ const PoliciesTable = ({ onQueryChange={onQueryChange} inputPlaceHolder="Search by name" searchable={searchable} + disableTableHeader={!searchable} customControl={customControl} /> diff --git a/frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx b/frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx index 619c2d1084c..f0cf21160f0 100644 --- a/frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx +++ b/frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx @@ -302,6 +302,7 @@ const QueriesTable = ({ inputPlaceHolder="Search by name" onQueryChange={onQueryChange} searchable={searchable} + disableTableHeader={!searchable} customControl={searchable ? renderPlatformDropdown : undefined} disableMultiRowSelect={!curTeamScopeQueriesPresent} onClickRow={handleRowSelect} From 396f8f454a10f9d51369863b1750657e1f4b44e7 Mon Sep 17 00:00:00 2001 From: Luke Heath Date: Fri, 8 May 2026 16:24:10 -0500 Subject: [PATCH 2/3] Remove changes file (unreleased bugs) --- changes/44923-style-fixes | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 changes/44923-style-fixes diff --git a/changes/44923-style-fixes b/changes/44923-style-fixes deleted file mode 100644 index 5a1f6d2cb3c..00000000000 --- a/changes/44923-style-fixes +++ /dev/null @@ -1,3 +0,0 @@ -* Moved the "Save" button to the left of "Cancel" on the Add/edit label page. -* Removed the empty filter row above the empty state on the Reports and Policies pages so the empty state sits closer to the page header. -* Cleaned up dark-mode styling on the initial Fleet setup page (active breadcrumb, input field hover/active borders, and confirmation table row backgrounds). From 0e50cfc65e07d4a9b3d15fe03592e170224ef5f7 Mon Sep 17 00:00:00 2001 From: Luke Heath Date: Fri, 8 May 2026 16:27:09 -0500 Subject: [PATCH 3/3] Fix Save/Cancel order on New label page --- .../pages/labels/NewLabelPage/NewLabelPage.tsx | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/frontend/pages/labels/NewLabelPage/NewLabelPage.tsx b/frontend/pages/labels/NewLabelPage/NewLabelPage.tsx index 4f61ab06b73..2602162706f 100644 --- a/frontend/pages/labels/NewLabelPage/NewLabelPage.tsx +++ b/frontend/pages/labels/NewLabelPage/NewLabelPage.tsx @@ -594,15 +594,6 @@ const NewLabelPage = ({ {renderVariableFields()}
- ( @@ -615,6 +606,15 @@ const NewLabelPage = ({ )} /> +
);