Skip to content

Commit 5f348b8

Browse files
authored
Fix build report timing issue (#1839)
1 parent d482fe8 commit 5f348b8

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

scripts/gha/report_build_status.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,9 @@
127127
_FLAKY_TEXT = "Pass (flaky)"
128128
_MISSING_TEXT = "Missing"
129129

130-
general_test_time = ' 09:0'
131-
firestore_test_time = ' 10:0'
130+
general_test_hour = 9
131+
firestore_test_hour = 10
132+
test_time_minute_range = 20
132133

133134
def rename_key(old_dict,old_name,new_name):
134135
"""Rename a key in a dictionary, preserving the order."""
@@ -386,8 +387,10 @@ def main(argv):
386387
if run['status'] != 'completed': continue
387388
if run['day'] < start_date or run['day'] > end_date: continue
388389
run['duration'] = dateutil.parser.parse(run['updated_at'], ignoretz=True) - run['date']
389-
compare_test_time = firestore_test_time if FLAGS.firestore else general_test_time
390-
if compare_test_time in str(run['date']):
390+
compare_test_hour = firestore_test_hour if FLAGS.firestore else general_test_hour
391+
# The general test should start at 9:00, and firestore at 10:00, but we give it a range
392+
# because the tests can take a few minutes before starting.
393+
if run['date'].hour == compare_test_hour and run['date'].minute <= test_time_minute_range:
391394
source_tests[day] = run
392395
all_days.add(day)
393396

0 commit comments

Comments
 (0)