libtesseract5-5.5.2-1 build failure on 10.14.6 (recursive_directory_iterator introduced in 10.15)

[nieder]

Building v5.5.2-1 on 10.14.6:

/bin/sh ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H   -DHAVE_FRAMEWORK_ACCELERATE  -O2 -DNDEBUG -I./include -I./include  -DTESS_COMMON_TRAINING_API= -I./src/arch -I./src/ccmain -I./src/ccstruct -I./src/ccutil -I./src/classify -I./src/cutil -I./src/dict -I./src/lstm -I./src/textord -I./src/training/common -I./src/viewer -I./src/wordrec -I/sw/include -I/sw/include -I/sw/include/leptonica -I/sw/include  -g -O2 -std=c++17 -MT src/api/libtesseract_la-baseapi.lo -MD -MP -MF src/api/.deps/libtesseract_la-baseapi.Tpo -c -o src/api/libtesseract_la-baseapi.lo `test -f 'src/api/baseapi.cpp' || echo './'`src/api/baseapi.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -DHAVE_FRAMEWORK_ACCELERATE -O2 -DNDEBUG -I./include -I./include -DTESS_COMMON_TRAINING_API= -I./src/arch -I./src/ccmain -I./src/ccstruct -I./src/ccutil -I./src/classify -I./src/cutil -I./src/dict -I./src/lstm -I./src/textord -I./src/training/common -I./src/viewer -I./src/wordrec -I/sw/include -I/sw/include -I/sw/include/leptonica -I/sw/include -g -O2 -std=c++17 -MT src/api/libtesseract_la-baseapi.lo -MD -MP -MF src/api/.deps/libtesseract_la-baseapi.Tpo -c src/api/baseapi.cpp  -fno-common -DPIC -o src/api/.libs/libtesseract_la-baseapi.o
src/api/baseapi.cpp:150:25: error: 'recursive_directory_iterator' is unavailable: introduced in macOS 10.15
       std::filesystem::recursive_directory_iterator(datadir,
                        ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2507:7: note: 
      'recursive_directory_iterator' has been explicitly marked unavailable here
class recursive_directory_iterator {
      ^
src/api/baseapi.cpp:151:71: error: 'operator|' is unavailable: introduced in macOS 10.15
         std::filesystem::directory_options::follow_directory_symlink |
                                                                      ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:455:36: note: 'operator|'
      has been explicitly marked unavailable here
inline constexpr directory_options operator|(directory_options _LHS,
                                   ^
src/api/baseapi.cpp:150:54: error: 'path' is unavailable: introduced in macOS 10.15
       std::filesystem::recursive_directory_iterator(datadir,
                                                     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:773:3: note: 'path' has
      been explicitly marked unavailable here
  path(const _Source& __src, format = format::auto_format) {
  ^
src/api/baseapi.cpp:150:54: error: '~path' is unavailable: introduced in macOS 10.15
       std::filesystem::recursive_directory_iterator(datadir,
                                                     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:791:3: note: '~path' has
      been explicitly marked unavailable here
  ~path() = default;
  ^
src/api/baseapi.cpp:150:8: error: 'recursive_directory_iterator' is unavailable: introduced in macOS 10.15
       std::filesystem::recursive_directory_iterator(datadir,
       ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2521:12: note: 
      'recursive_directory_iterator' has been explicitly marked unavailable here
  explicit recursive_directory_iterator(
           ^
src/api/baseapi.cpp:150:8: error: 'recursive_directory_iterator' is unavailable: introduced in macOS 10.15
       std::filesystem::recursive_directory_iterator(datadir,
       ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2521:12: note: 
      'recursive_directory_iterator' has been explicitly marked unavailable here
  explicit recursive_directory_iterator(
           ^
src/api/baseapi.cpp:150:8: error: '~recursive_directory_iterator' is unavailable: introduced in macOS 10.15
       std::filesystem::recursive_directory_iterator(datadir,
       ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2551:3: note: 
      '~recursive_directory_iterator' has been explicitly marked unavailable here
  ~recursive_directory_iterator() = default;
  ^
src/api/baseapi.cpp:149:26: error: 'begin' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2629:1: note: 'begin' has
      been explicitly marked unavailable here
begin(recursive_directory_iterator __iter) noexcept {
^
src/api/baseapi.cpp:149:26: error: 'recursive_directory_iterator' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2534:3: note: 
      'recursive_directory_iterator' has been explicitly marked unavailable here
  recursive_directory_iterator(const recursive_directory_iterator&) = default;
  ^
src/api/baseapi.cpp:149:26: error: '~recursive_directory_iterator' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2551:3: note: 
      '~recursive_directory_iterator' has been explicitly marked unavailable here
  ~recursive_directory_iterator() = default;
  ^
src/api/baseapi.cpp:149:26: error: '~recursive_directory_iterator' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2551:3: note: 
      '~recursive_directory_iterator' has been explicitly marked unavailable here
  ~recursive_directory_iterator() = default;
  ^
src/api/baseapi.cpp:149:26: error: '~recursive_directory_iterator' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2551:3: note: 
      '~recursive_directory_iterator' has been explicitly marked unavailable here
  ~recursive_directory_iterator() = default;
  ^
src/api/baseapi.cpp:149:26: error: 'end' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2634:1: note: 'end' has
      been explicitly marked unavailable here
end(const recursive_directory_iterator&) noexcept {
^
src/api/baseapi.cpp:149:26: error: '~recursive_directory_iterator' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2551:3: note: 
      '~recursive_directory_iterator' has been explicitly marked unavailable here
  ~recursive_directory_iterator() = default;
  ^
src/api/baseapi.cpp:149:26: error: '~recursive_directory_iterator' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2551:3: note: 
      '~recursive_directory_iterator' has been explicitly marked unavailable here
  ~recursive_directory_iterator() = default;
  ^
src/api/baseapi.cpp:149:26: error: 'operator!=' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2623:13: note: 
      'operator!=' has been explicitly marked unavailable here
inline bool operator!=(const recursive_directory_iterator& __lhs,
            ^
src/api/baseapi.cpp:149:26: error: 'operator++' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2559:33: note: 
      'operator++' has been explicitly marked unavailable here
  recursive_directory_iterator& operator++() { return __increment(); }
                                ^
src/api/baseapi.cpp:149:26: error: 'operator*' is unavailable: introduced in macOS 10.15
  for (const auto& entry :
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:2554:26: note: 
      'operator*' has been explicitly marked unavailable here
  const directory_entry& operator*() const { return __dereference(); }
                         ^

[dmacks]

I won't have a chance to look at this for a few days. Feel free to dist-restrict. But also anyone who knows anything about this is welcome to push fixes.

[nieder]

Setting CXX to g++-fsf-12 -flax-vector-conversions got it working. The -f flag was needed to get around unallowed vector conversions with the standard g++ config.

We need to figure out if we need to get rid of earlier dists. 10.12 is already problematic (#1247 fix #1295) and 10.14 sometimes (probably even 11 and lower).

[dmacks]

The "EOL" mechanism we've used before should continue to work if we don't want to spawn off a whole new dists/ directory. One of my less-proud hacks that I think especially TheSin hates (with good reason) :)

[dmacks]

Setting CXX to g++-fsf-12 -flax-vector-conversions got it working. The -f flag was needed to get around unallowed vector conversions with the standard g++ config.

That would require variants because we don't have gcc12 on Tahoe/arm (for example, #1080).

[nieder]

Don't have (restricted) or doesn't build? Comment 1 in #1080 suggests it works for arm64 (but no mention of Tahoe). I currently have no working Mac so can't follow up on anything.

[sth0]

The current gcc12 does NOT build on arm64 or X86_64 for Tahoe 12.5. See #1080