emacs28-app

[okayamat]

New upstream for emacs28-app (finkinfo and patches are attached). I tested it on macOS Sequoia 15.4.
emacs28-app.zip

[nieder]

On 10.14.6, I get this build error:

  CC       malloc/dynarray_emplace_enlarge.o
clang: warning: argument unused during compilation: '-MMD' [-Wunused-command-line-argument]
malloc/dynarray_emplace_enlarge.c:30:41: warning: declaration of 'struct dynarray_header' will not be visible outside of this function
      [-Wvisibility]
__libc_dynarray_emplace_enlarge (struct dynarray_header *list,
                                        ^
malloc/dynarray_emplace_enlarge.c:34:11: error: incomplete definition of type 'struct dynarray_header'
  if (list->allocated == 0)
      ~~~~^
malloc/dynarray_emplace_enlarge.c:30:41: note: forward declaration of 'struct dynarray_header'
__libc_dynarray_emplace_enlarge (struct dynarray_header *list,
                                        ^
malloc/dynarray_emplace_enlarge.c:49:27: error: incomplete definition of type 'struct dynarray_header'
      new_allocated = list->allocated + list->allocated / 2 + 1;
                      ~~~~^
malloc/dynarray_emplace_enlarge.c:30:41: note: forward declaration of 'struct dynarray_header'
__libc_dynarray_emplace_enlarge (struct dynarray_header *list,
                                        ^

[nieder]

Googling around some found the problem is due to a header conflict with hdf, so emacs28-app will need to either BuildConflicts with hdf or fix the compiler flag ordering so that internal headers are read before Fink or system-headers.

Removing hdf locally, I then get this error:

Writing package script prerm...
Writing md5sums file...
Validating .deb dir /sw/build.build/root-emacs28-app-28.2-0...
Error: Texinfo file found but no InfoDocs field in package description.
	Offending file: /sw/share/info/emacs-28/
	Offending file: /sw/share/info/emacs-28/reftex.info.gz
	Offending file: /sw/share/info/emacs-28/message.info.gz
	Offending file: /sw/share/info/emacs-28/epa.info.gz
	Offending file: /sw/share/info/emacs-28/autotype.info.gz
	Offending file: /sw/share/info/emacs-28/sasl.info.gz
	Offending file: /sw/share/info/emacs-28/transient.info.gz

[nieder]

Lastly, fink-package-precedence says:

Found use of headers from 5 fink packages:
	giflib7
	gmp5
	libiconv-dev
	libjansson4
	libxml2

[okayamat]

Googling around some found the problem is due to a header conflict with hdf, so emacs28-app will need to either BuildConflicts with hdf or fix the compiler flag ordering so that internal headers are read before Fink or system-headers.

Removing hdf locally, I then get this error:

Writing package script prerm...
Writing md5sums file...
Validating .deb dir /sw/build.build/root-emacs28-app-28.2-0...
Error: Texinfo file found but no InfoDocs field in package description.
	Offending file: /sw/share/info/emacs-28/
	Offending file: /sw/share/info/emacs-28/reftex.info.gz
	Offending file: /sw/share/info/emacs-28/message.info.gz
	Offending file: /sw/share/info/emacs-28/epa.info.gz
	Offending file: /sw/share/info/emacs-28/autotype.info.gz
	Offending file: /sw/share/info/emacs-28/sasl.info.gz
	Offending file: /sw/share/info/emacs-28/transient.info.gz

Firstly I made the finkinfo based on emacs26-app.info, which does install-info manually in PostInstScript and PreRmScript. However, dpkg output errors saying that do not call install-info manually in postinst (or prerm). Therefore, I simply remove the process from PostInstScript/PreRmScript. Nevertheless, dpkg calls a trigger that automatically execute install-info and register existing info files.
Is InfoDocs entry needed? If so, use the attached file.

EDIT: forgot to add BuildConflicts: hdf, please add appropriately if needed.

emacs28-app.txt

[okayamat]

Lastly, fink-package-precedence says:

Found use of headers from 5 fink packages:
	giflib7
	gmp5
	libiconv-dev
	libjansson4
	libxml2

Is "BuildConflicts: giflib7, gmp5, libjansson4" needed? Not intended to use these headers.

[nieder]

There's a --without-libgmp flag. According to ./configure, use of jansson is controlled by the --with-json flag.
Not sure why --without-gif is being ignored, though it might be able to short-circuit the test by adding ac_cv_header_gif_lib_h=no to %c.

Alternative is to explicitly activate all those features instead and add the libraries to (Build)Depends.

[dmacks]

Why would this package want to avoid using those other packages? Especially giflib7 and libjansson4 seem pretty lightweight.

Fixing flag-ordering should be the very first approach. Maintainers never know what new packages a user might install in the future that have yet other headers that cause problems. BuildConflicts is always fragile and leads to build-failures that can be difficult to diagnose.

[okayamat]

In the attached finkinfo, the following fields are modified.

Depends: giflib7-shlibs, libjansson4-shlibs
BuildDepends: giflib7, libjansson4
BuildConflicts: hdf
ConfigureParams: --with-json --with-gif --without-libgmp

emacs28-app.txt

[nieder]

So with --without-libgmp, the build fails like this (I turned off silent rules to see the compiler command):

Does Emacs use the GMP library? no
...
gcc -o temacs.tmp
-Demacs -I. -I. -I../lib -I../lib -I/sw/include/libxml2 -I/sw/include -MMD -MF deps/.d -MP -I/sw/include -Wno-switch -Wno-pointer-sign -Wno-string-plus-int -Wno-unknown-attributes -Wno-initializer-overrides -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare -O1 -framework AppKit -framework Carbon -framework Cocoa -framework IOKit -framework Carbon -framework IOSurface -framework QuartzCore -L/sw/lib
dispnew.o frame.o scroll.o xdisp.o menu.o window.o charset.o coding.o category.o ccl.o character.o chartab.o bidi.o cm.o term.o terminal.o xfaces.o emacs.o keyboard.o macros.o keymap.o sysdep.o bignum.o buffer.o filelock.o insdel.o marker.o minibuf.o fileio.o dired.o cmds.o casetab.o casefiddle.o indent.o search.o regex-emacs.o undo.o alloc.o pdumper.o data.o doc.o editfns.o callint.o eval.o floatfns.o fns.o font.o print.o lread.o emacs-module.o syntax.o bytecode.o comp.o dynlib.o process.o gnutls.o callproc.o region-cache.o sound.o timefns.o atimer.o doprnt.o intervals.o textprop.o composite.o xml.o lcms.o kqueue.o profiler.o decompress.o thread.o systhread.o fontset.o fringe.o image.o json.o nsterm.o nsfns.o nsmenu.o nsselect.o nsimage.o macim.o macfont.o terminfo.o lastfile.o ../lib/libgnu.a -lgif -L/sw/lib -lxml2 -lncurses -lz -L/sw/lib -ljansson
Undefined symbols for architecture x86_64:
"___gmp_set_memory_functions", referenced from:
_init_bignum in bignum.o
"___gmpz_abs", referenced from:
_rounddiv_q in floatfns.o
"___gmpz_add", referenced from:

So it says no GMP in configure, but then still build gmp bits, but fails because there's no -lgmp flag.

config.h says this as expected because GMP was disabled in configure:

/* Define to 1 if you have the <gmp/gmp.h> header file. */
/* #undef HAVE_GMP_GMP_H */

/* Define to 1 if you have the <gmp.h> header file. */
/* #undef HAVE_GMP_H */

but those guards are not used anywhere in the code.

[okayamat]

Added BuildConflicts: gmp5, it seems fine at least for me.

emacs28-app.txt