fix(cli): fix false "page was moved" warnings for versioned docs pages#16036
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix(cli): fix false "page was moved" warnings for versioned docs pages#16036devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: will.kendall@buildwithfern.com <wpk235@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes false "page was moved" warnings in
fern checkandfern docs devwhen the same.mdxfile is intentionally referenced across multiple doc versions.Changes Made
buildPageIdToSlugMap: Changed return type fromMap<string, string>toMap<string, Set<string>>so that all slugs are tracked per pageId (instead of the last one overwriting earlier entries)findRemovedSlugs: Updated to accept the new multi-slug map type. TheactiveSlugsset now correctly contains all slugs from all navigation entries, preventing false positives when the same file appears under multiple version slugsRoot Cause
buildPageIdToSlugMapreturnedMap<string, string>, so when the same file appeared in multiple version navigation entries (e.g.,safety-notices.mdxunder both v2-2-77 and v2-3-2), only the last slug survived.findRemovedSlugsthen saw the published slug didn't match the single local slug and wasn't inactiveSlugs, incorrectly flagging it as "moved".Testing
Link to Devin session: https://app.devin.ai/sessions/9be668fc08984ce4ad8967a0bcde10d9