Tests.

Author: benubois

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
 
     - uses: actions/setup-node@v4
       with:
-        node-version: 23
+        node-version: 20
         cache: "npm"
     - run: npm ci
 

Gemfile

@@ -11,4 +11,5 @@ gem "http"
 group :test do
   gem "minitest"
   gem "webmock"
+  gem "rack-test"
 end

Gemfile.lock

@@ -44,6 +44,8 @@ GEM
     rack-session (2.1.1)
       base64 (>= 0.1.0)
       rack (>= 3.0.0)
+    rack-test (2.2.0)
+      rack (>= 1.3)
     raindrops (0.20.1)
     rake (13.3.0)
     rexml (3.4.1)
@@ -73,6 +75,7 @@ DEPENDENCIES
   http
   minitest
   puma
+  rack-test
   sd_notify
   sinatra
   unicorn

app/app.rb

@@ -6,14 +6,22 @@
 require "base64"
 require "connection_pool"
 
-set :protection, except: [:json_csrf]
+if ENV["RACK_ENV"] == "test"
+  set :protection, false
+else
+  set :protection, except: [:json_csrf]
+end
 
 $parser = ConnectionPool.new(size: 1, timeout: 5) {
   HTTP.persistent(ENV["PARSER_URL"])
 }
 
 def signature_valid?(user, signature, data)
-  path = File.expand_path(File.join("..", "users", user), __dir__)
+  if ENV["RACK_ENV"] == "test"
+    path = File.join("users", user)
+  else
+    path = File.expand_path(File.join("..", "users", user), __dir__)
+  end
   key = File.read(path).strip
   signature == OpenSSL::HMAC.hexdigest("sha1", key, data)
 end

test/app_test.rb

@@ -1,4 +1,73 @@
+require "webmock/minitest"
 require_relative "test_helper"
 
-class AppTest < Minitest::Test
+class AppTest < Test
+
+  def test_health_check
+    get "/health_check"
+    assert_equal 200, last_response.status
+    assert_equal "OK", last_response.body
+  end
+
+  def test_parser_with_valid_signature
+    user = "testuser"
+    url = "https://example.com"
+    base64_url = Base64.urlsafe_encode64(url)
+    key = "secret-key"
+    signature = OpenSSL::HMAC.hexdigest("sha1", key, url)
+
+    response = JSON.dump({title: "Test Page"})
+
+    Dir.mktmpdir do |dir|
+      users_dir = File.join(dir, "users")
+      Dir.mkdir(users_dir)
+      File.write(File.join(users_dir, user), key)
+
+      Dir.chdir(dir) do
+        stub_request(:get, url)
+          .to_return(
+            status: 200,
+            body: response,
+            headers: {"Content-Type" => "application/json"}
+          )
+
+        stub_request(:post, "#{ENV["PARSER_URL"]}/parser")
+          .to_return(
+            status: 200,
+            body: response,
+            headers: {"Content-Type" => "application/json"}
+          )
+
+        get "/parser/#{user}/#{signature}?base64_url=#{base64_url}"
+
+        assert_equal 200, last_response.status
+        assert_equal "application/json", last_response.content_type
+        assert_equal JSON.load(response), JSON.load(last_response.body)
+      end
+    end
+  end
+
+  def test_parser_with_invalid_signature
+    user = "testuser"
+    url = "https://example.com"
+    base64_url = Base64.urlsafe_encode64(url)
+    invalid_signature = "invalid"
+
+    Dir.mktmpdir do |dir|
+      users_dir = File.join(dir, "users")
+      Dir.mkdir(users_dir)
+      File.write(File.join(users_dir, user), "secret-key")
+
+      Dir.chdir(dir) do
+        get "/parser/#{user}/#{invalid_signature}?base64_url=#{base64_url}"
+
+        assert_equal 400, last_response.status
+        assert_equal "application/json", last_response.content_type
+
+        body = JSON.parse(last_response.body)
+        assert_equal true, body["error"]
+        assert_equal "Invalid signature.", body["messages"]
+      end
+    end
+  end
 end

test/test_helper.rb

@@ -1,3 +1,17 @@
+ENV["RACK_ENV"] = "test"
+ENV["PARSER_URL"] = "http://parser.test"
+
 require "minitest/autorun"
 require "webmock/minitest"
-require_relative "../app/app.rb"
+require "rack/test"
+require "json"
+require "tmpdir"
+require_relative "../app/app.rb"
+
+class Test < Minitest::Test
+  include Rack::Test::Methods
+
+  def app
+    Sinatra::Application
+  end
+end