fix(lib/schemes/urn): check nid for undefined (#141)

* fix(lib/schemes/urn): check nid for undefined

* Throw error on undefined nid

* Restore test for equals

* remove dups after rebase

Author: wooffie

lib/schemes.js

@@ -152,6 +152,9 @@ function urnParse (urnComponent, options) {
 
 /** @type {SchemeFn} */
 function urnSerialize (urnComponent, options) {
+  if (urnComponent.nid === undefined) {
+    throw new Error('URN without nid cannot be serialized')
+  }
   const scheme = options.scheme || urnComponent.scheme || 'urn'
   const nid = urnComponent.nid.toLowerCase()
   const urnScheme = `${scheme}:${options.nid || nid}`

test/equal.test.js

@@ -65,6 +65,11 @@ test('URN Equals', (t) => {
   // t.equal(URI.equal('urn:foo:a123%2C456', 'URN:FOO:a123%2c456'), true)
 
   runTest(t, suite)
+
+  t.throws(() => {
+    fn('urn:', 'urn:FOO:a123,456')
+  }, 'URN without nid cannot be serialized')
+
   t.end()
 })
 

test/serialize.test.js

@@ -101,7 +101,7 @@ test('WSS serialize', (t) => {
 })
 
 test('URN serialize', (t) => {
-// example from RFC 2141
+  // example from RFC 2141
   const components = {
     scheme: 'urn',
     nid: 'foo',
@@ -122,6 +122,14 @@ test('URN serialize', (t) => {
     uuid: 'notauuid-7dec-11d0-a765-00a0c91e6bf6'
   }
   t.equal(fastURI.serialize(uuidcomponents), 'urn:uuid:notauuid-7dec-11d0-a765-00a0c91e6bf6')
+
+  uuidcomponents = {
+    scheme: 'urn',
+    nid: undefined,
+    uuid: 'notauuid-7dec-11d0-a765-00a0c91e6bf6'
+  }
+  t.throws(() => { fastURI.serialize(uuidcomponents) }, 'URN without nid cannot be serialized')
+
   t.end()
 })
 test('URN NID Override', (t) => {