use nonSimpleDomain with regex

Author: Uzlopak

benchmark/non-simple-domain.mjs

@@ -0,0 +1,22 @@
+import { Bench } from 'tinybench'
+import { nonSimpleDomain } from '../lib/utils.js'
+
+const benchNonSimpleDomain = new Bench({ name: 'nonSimpleDomain' })
+
+const exampleCom = 'example.com'
+const exaumlmpleCom = 'exämple.com'
+const longDomain = 'abc'.repeat(100) + '.com'
+
+console.assert(nonSimpleDomain(exampleCom) === false, 'example.com should be a simple domain')
+console.assert(nonSimpleDomain(exaumlmpleCom) === true, 'exämple.com should not be a simple domain')
+console.assert(nonSimpleDomain(longDomain) === false, `${longDomain} should be a simple domain?`)
+
+benchNonSimpleDomain.add('nonSimpleDomain', function () {
+  nonSimpleDomain(exampleCom)
+  nonSimpleDomain(exaumlmpleCom)
+  nonSimpleDomain(longDomain)
+})
+
+await benchNonSimpleDomain.run()
+console.log(benchNonSimpleDomain.name)
+console.table(benchNonSimpleDomain.table())

index.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { normalizeIPv6, removeDotSegments, recomposeAuthority, normalizeComponentEncoding, isIPv4 } = require('./lib/utils')
+const { normalizeIPv6, removeDotSegments, recomposeAuthority, normalizeComponentEncoding, isIPv4, nonSimpleDomain } = require('./lib/utils')
 const { SCHEMES, getSchemeHandler } = require('./lib/schemes')
 
 /**
@@ -211,23 +211,6 @@ function serialize (cmpts, opts) {
   return uriTokens.join('')
 }
 
-const hexLookUp = Array.from({ length: 127 }, (_v, k) => /[^!"$&'()*+,\-.;=_`a-z{}~]/u.test(String.fromCharCode(k)))
-
-/**
- * @param {string} value
- * @returns {boolean}
- */
-function nonSimpleDomain (value) {
-  let code = 0
-  for (let i = 0, len = value.length; i < len; ++i) {
-    code = value.charCodeAt(i)
-    if (code > 126 || hexLookUp[code]) {
-      return true
-    }
-  }
-  return false
-}
-
 const URI_PARSE = /^(?:([^#/:?]+):)?(?:\/\/((?:([^#/?@]*)@)?(\[[^#/?\]]+\]|[^#/:?]*)(?::(\d*))?))?([^#?]*)(?:\?([^#]*))?(?:#((?:.|[\n\r])*))?/u
 
 /**

lib/utils.js

@@ -43,6 +43,12 @@ function stringArrayToHexStripped (input) {
  * @property {string} [zone] - The zone identifier, if present.
  */
 
+/**
+ * @param {string} value
+ * @returns {boolean}
+ */
+const nonSimpleDomain = RegExp.prototype.test.bind(/[^!"$&'()*+,\-.;=_`a-z{}~]/u)
+
 /**
  * @param {string} input
  * @returns {GetIPV6Result}
@@ -305,6 +311,7 @@ function recomposeAuthority (components) {
 };
 
 module.exports = {
+  nonSimpleDomain,
   recomposeAuthority,
   normalizeComponentEncoding,
   removeDotSegments,