fix: comprehensive repository audit — CI, runtime bugs, code quality, devcontainer

- GitVersion.yml: add copilot branch pattern to prevent >63-char helm labels
- deployment.yaml: add missing APP_ prefix to all env var names (runtime bug)
- Cargo.toml: remove unused serde_json dependency
- src/main.rs: fix misleading comment (INFO → DEBUG default log level)
- Dockerfile: use absolute path in ENTRYPOINT
- build.sh: fix shebang (sh → bash) to match bash-specific read -p usage
- Chart.yaml: replace helm create placeholder appVersion 1.16.0 with 0.0.0
- .devcontainer: update to current mcr.microsoft.com/devcontainers/rust:1-bookworm
- devcontainer.json: fix deprecated rust-analyzer.checkOnSave.command setting

Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com>
Agent-Logs-Url: https://github.com/f2calv/multi-arch-container-rust/sessions/2d38c791-ae0e-4533-98a2-0094712253fe

Author: Copilot

.devcontainer/Dockerfile

@@ -1,8 +1,7 @@
-# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.245.2/containers/rust/.devcontainer/base.Dockerfile
+# See here for image contents: https://github.com/devcontainers/images/tree/main/src/rust
 
-# [Choice] Debian OS version (use bullseye on local arm64/Apple Silicon): buster, bullseye
-ARG VARIANT="buster"
-FROM mcr.microsoft.com/vscode/devcontainers/rust:0-${VARIANT}
+ARG VARIANT="bookworm"
+FROM mcr.microsoft.com/devcontainers/rust:1-${VARIANT}
 
 # [Optional] Uncomment this section to install additional packages.
 # RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \

.devcontainer/devcontainer.json

@@ -1,13 +1,12 @@
 // For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
-// https://github.com/microsoft/vscode-dev-containers/tree/v0.245.2/containers/rust
+// https://github.com/devcontainers/images/tree/main/src/rust
 {
 	"name": "Rust",
 	"build": {
 		"dockerfile": "Dockerfile",
 		"args": {
-			// Use the VARIANT arg to pick a Debian OS version: buster, bullseye
-			// Use bullseye when on local on arm64/Apple Silicon.
-			"VARIANT": "bullseye"
+			// Use the VARIANT arg to pick a Debian OS version: bookworm, bullseye
+			"VARIANT": "bookworm"
 		}
 	},
 	"runArgs": [
@@ -40,7 +39,7 @@
 				"files.watcherExclude": {
 					"**/target/**": true
 				},
-				"rust-analyzer.checkOnSave.command": "clippy"
+				"rust-analyzer.check.command": "clippy"
 			},
 			// Add the IDs of extensions you want installed when the container is created.
 			"extensions": [

Cargo.lock

@@ -13,5 +13,4 @@ log = "0"
 ctrlc = "3"
 tokio = { version = "1", features = ["full"] }
 serde = { version = "1", features = ["derive"] }
-serde_json = "1"
 sys-info = "0"

Cargo.toml

@@ -92,4 +92,4 @@ ENV APP_GITHUB_RUN_ID=$GITHUB_RUN_ID
 ARG GITHUB_RUN_NUMBER
 ENV APP_GITHUB_RUN_NUMBER=$GITHUB_RUN_NUMBER
 
-ENTRYPOINT ["./multi-arch-container-rust"]
+ENTRYPOINT ["/multi-arch-container-rust"]

Dockerfile

@@ -6,6 +6,9 @@ branches:
   feature:
     regex: ^features?[/-]
     tag: useBranchName
+  copilot:
+    regex: ^copilot[/-]
+    tag: 'copilot'
 ignore:
   sha: []
 merge-message-formats: {}

GitVersion.yml

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 #set variables to emulate running in the workflow/pipeline
 GIT_REPOSITORY=$(basename `git rev-parse --show-toplevel`)

build.sh

@@ -21,4 +21,4 @@ version: 0.1.0
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "1.16.0"
+appVersion: "0.0.0"

charts/multi-arch-container-rust/Chart.yaml

@@ -46,21 +46,21 @@ spec:
               protocol: TCP
           env:
             {{- if hasKey .Values "git" }}
-            - name: "GIT_REPOSITORY"
+            - name: "APP_GIT_REPOSITORY"
               value: {{ .Values.git.repository | default "" | quote }}
-            - name: "GIT_BRANCH"
+            - name: "APP_GIT_BRANCH"
               value: {{ .Values.git.branch | default "" | quote }}
-            - name: "GIT_COMMIT"
+            - name: "APP_GIT_COMMIT"
               value: {{ .Values.git.commit | default "" | quote }}
             {{- end }}
-            - name: "GIT_TAG"
-              value: {{ .Values.image.tag | default .Chart.AppVersion }}
+            - name: "APP_GIT_TAG"
+              value: {{ .Values.image.tag | default .Chart.AppVersion | quote }}
             {{- if hasKey .Values "github" }}
-            - name: "GITHUB_WORKFLOW"
+            - name: "APP_GITHUB_WORKFLOW"
               value: {{ .Values.github.workflow | default "" | quote }}
-            - name: "GITHUB_RUN_ID"
+            - name: "APP_GITHUB_RUN_ID"
               value: {{ .Values.github.run_id | int64 | default 0 | quote }}
-            - name: "GITHUB_RUN_NUMBER"
+            - name: "APP_GITHUB_RUN_NUMBER"
               value: {{ .Values.github.run_number | int64 | default 0 | quote }}
             {{- end }}
           {{- if hasKey .Values "livenessProbe" }}

charts/multi-arch-container-rust/templates/deployment.yaml

@@ -7,7 +7,7 @@ use sys_info::*;
 
 #[tokio::main]
 async fn main() -> std::io::Result<()> {
-    // Set INFO logging level as default
+    // Set DEBUG logging level as default
     env_logger::Builder::from_env(Env::default().default_filter_or("debug")).init();
 
     //Load app settings from env variables