Skip to content

Commit ab8aa1a

Browse files
committed
make mypy happy
1 parent d563ff7 commit ab8aa1a

2 files changed

Lines changed: 19 additions & 8 deletions

File tree

src/enochecker3/enochecker.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,9 @@ async def _call_putflag(
494494
attack_info: Optional[str | bytes] = await self._call_method(task)
495495
if isinstance(attack_info, bytes):
496496
attack_info = attack_info.decode()
497-
get_current_span().set_attribute("enochecker.result.attack_info", attack_info)
497+
get_current_span().set_attribute(
498+
"enochecker.result.attack_info", attack_info if attack_info else "None"
499+
)
498500
return CheckerResultMessage(
499501
result=CheckerTaskResult.OK, attack_info=attack_info
500502
)
@@ -929,7 +931,9 @@ async def checker(task: CheckerTaskMessage) -> CheckerResultMessage:
929931
except MumbleException as e:
930932
span.record_exception(e)
931933
span.set_attribute("enochecker.result", "MUMBLE")
932-
span.set_attribute("enochecker.result.message", e.message)
934+
span.set_attribute(
935+
"enochecker.result.message", e.message if e.message else "None"
936+
)
933937
trace = traceback.format_exc()
934938
if e.log_message:
935939
logger.info(e.log_message)
@@ -940,7 +944,9 @@ async def checker(task: CheckerTaskMessage) -> CheckerResultMessage:
940944
except OfflineException as e:
941945
span.record_exception(e)
942946
span.set_attribute("enochecker.result", "OFFLINE")
943-
span.set_attribute("enochecker.result.message", e.message)
947+
span.set_attribute(
948+
"enochecker.result.message", e.message if e.message else "None"
949+
)
944950
trace = traceback.format_exc()
945951
if e.log_message:
946952
logger.info(e.log_message)
@@ -952,7 +958,9 @@ async def checker(task: CheckerTaskMessage) -> CheckerResultMessage:
952958
span.record_exception(e)
953959
span.set_status(StatusCode.ERROR)
954960
span.set_attribute("enochecker.result", "INTERNAL_ERROR")
955-
span.set_attribute("enochecker.result.message", e.message)
961+
span.set_attribute(
962+
"enochecker.result.message", e.message if e.message else "None"
963+
)
956964
trace = traceback.format_exc()
957965
if e.log_message:
958966
logger.info(e.log_message)

src/enochecker3/telemetry.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
from opentelemetry.sdk._logs._internal.export import (
1414
BatchLogRecordProcessor,
1515
LogRecordExporter,
16+
LogRecordProcessor,
1617
SimpleLogRecordProcessor,
1718
)
1819
from opentelemetry.sdk.resources import SERVICE_NAME, Resource
@@ -22,6 +23,7 @@
2223
BatchSpanProcessor,
2324
SimpleSpanProcessor,
2425
SpanExporter,
26+
SpanProcessor,
2527
)
2628
from opentelemetry.sdk.trace.sampling import ALWAYS_ON
2729
from opentelemetry.trace import Span, SpanKind, Tracer, _Links
@@ -34,7 +36,7 @@
3436
def _setup_logging(resource: Resource, log_exporter: LogRecordExporter) -> None:
3537
provider = LoggerProvider(resource=resource)
3638
if os.environ.get("OTEL_EXPORTER_DISABLE_BATCH", default=False):
37-
processor = SimpleLogRecordProcessor(log_exporter)
39+
processor: LogRecordProcessor = SimpleLogRecordProcessor(log_exporter)
3840
else:
3941
processor = BatchLogRecordProcessor(log_exporter)
4042
provider.add_log_record_processor(processor)
@@ -48,7 +50,7 @@ def _setup_logging(resource: Resource, log_exporter: LogRecordExporter) -> None:
4850
def _setup_tracing(resource: Resource, span_exporter: SpanExporter) -> None:
4951
provider = SaarctfTracerProvider(sampler=ALWAYS_ON, resource=resource)
5052
if os.environ.get("OTEL_EXPORTER_DISABLE_BATCH", default=False):
51-
processor = SimpleSpanProcessor(span_exporter)
53+
processor: SpanProcessor = SimpleSpanProcessor(span_exporter)
5254
else:
5355
processor = BatchSpanProcessor(span_exporter)
5456
provider.add_span_processor(processor)
@@ -194,8 +196,9 @@ async def async_request_hook(span: Span, request: RequestInfo):
194196
print(type(span))
195197
print(type(request))
196198
span.update_name(f"{request.method.decode()} {request.url}")
197-
for k, v in request.headers.items():
198-
span.set_attribute(f"http.headers.{k}", v)
199+
if request.headers:
200+
for k, v in request.headers.items():
201+
span.set_attribute(f"http.headers.{k}", v)
199202
print(request.method)
200203
print(request.url)
201204
print(request.headers)

0 commit comments

Comments
 (0)