build: detect macOS architecture for CMake#414
Merged
Conversation
Contributor
Author
|
Kinda duplicate of #331 |
qzhuyan
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #413.
Related to #329 and #377.
What changed
build.shnow setsCMAKE_OSX_ARCHITECTURESon macOS when the caller has not already provided it.The default is derived from the running Erlang VM via
erlang:system_info(system_architecture), with auname -mfallback. This keeps the NIF architecture aligned with the VM architecture and avoids Rosetta shell/host mismatches.The existing
SDKROOTsetup now also preserves a caller-providedSDKROOTinstead of unconditionally overwriting it.Why
msquic's OpenSSL/QuicTLS Darwin configure path expects
CMAKE_OSX_ARCHITECTURESto bearm64orx86_64. If CMake leaves it empty, the build can fall through to the generic OpenSSLconfigpath (ERRORWTF darwinin older msquic), causing architecture mismatch and/or bad-isysrootcompiler flags.Verified
On Apple Silicon/macOS:
Confirmed generated cache/configure output includes: