clean up rule changes history feature flags

Author: maximpn

x-pack/platform/plugins/shared/alerting/server/application/rule/methods/common_utils/log_rule_changes.ts

@@ -105,18 +105,15 @@ export async function logRuleChanges({
 
     const ruleType = getRuleType(ruleTypeRegistry, ruleSO.attributes.alertTypeId, logger);
 
-    // "ruleType.trackChanges" is activated at Alerting plugin's "plugin.ts".
-    //
-    // The activation is gated by the feature flag "xpack.alerting.ruleChangeTracking.enabled".
-    // On top of that "xpack.alerting.ruleChangeTracking.scope" controls what solution rule
-    // types will be activated, e.g. "security" or "observability".
-    //
+    // "ruleType.trackChanges" is activated at Alerting plugin's "plugin.ts", based on
+    // "xpack.alerting.ruleChangeTracking.scope", which controls what solution rule
+    // types are activated, e.g. "security" or "observability".
     if (!ruleType?.trackChanges) {
       continue;
     }
 
     // Security Solution additionally gates rule changes history per-space via its
-    // "Enable rule changes history" advanced setting, on top of the static config flag above.
+    // "Enable rule changes history" advanced setting.
     if (ruleType.solution === 'security') {
       if (securityRuleChangesHistoryEnabled === undefined) {
         try {

x-pack/platform/plugins/shared/alerting/server/config.test.ts

@@ -25,7 +25,6 @@ describe('config validation', () => {
           "removalDelay": "1h",
         },
         "ruleChangeTracking": Object {
-          "enabled": true,
           "scope": Array [
             "security",
           ],

x-pack/platform/plugins/shared/alerting/server/config.ts

@@ -92,7 +92,6 @@ export const configSchema = schema.object({
     totalFieldsLimit: schema.number({ defaultValue: 2800, min: 2500, max: 5000 }),
   }),
   ruleChangeTracking: schema.object({
-    enabled: schema.boolean({ defaultValue: true }),
     scope: schema.arrayOf(ruleChangeTrackingSolutions, { defaultValue: ['security'] }),
   }),
   cancelAlertsOnRuleTimeout: schema.boolean({ defaultValue: true }),

x-pack/platform/plugins/shared/alerting/server/plugin.ts

@@ -277,9 +277,7 @@ export class AlertingPlugin {
     this.disabledRuleTypes = new Set(this.config.disabledRuleTypes || []);
     this.enabledRuleTypes =
       this.config.enabledRuleTypes != null ? new Set(this.config.enabledRuleTypes) : null;
-    if (this.config.ruleChangeTracking.enabled) {
-      this.changeTrackingService = new ChangeTrackingService(this.logger, this.kibanaVersion);
-    }
+    this.changeTrackingService = new ChangeTrackingService(this.logger, this.kibanaVersion);
   }
 
   public setup(

x-pack/platform/plugins/shared/alerting/server/routes/rule/apis/create/create_rule_route.test.ts

@@ -51,7 +51,6 @@ describe('createRuleRoute', () => {
     },
     cancelAlertsOnRuleTimeout: true,
     ruleChangeTracking: {
-      enabled: false,
       scope: ['security'] as string[],
     },
     rules: {

x-pack/platform/plugins/shared/alerting/server/rules_client/methods/get_rule_history.ts

@@ -22,8 +22,7 @@ import type { RuleChangeHistorySnapshot } from '../lib/change_tracking';
 import { getRuleSo } from '../../data/rule';
 
 /**
- * Thrown by {@link RulesClient.getHistory} when rule change tracking is
- * disabled at the framework level (`xpack.alerting.ruleChangeTracking.enabled = false`).
+ * Thrown by {@link RulesClient.getHistory} when the change tracking service is unavailable.
  */
 export class RuleChangeTrackingDisabledError extends Error {
   constructor(message = 'Rule change tracking is disabled.') {

x-pack/platform/plugins/shared/alerting/server/test_utils/index.ts

@@ -59,7 +59,6 @@ export function generateAlertingConfig(overwrites: Partial<AlertingConfig> = {})
       totalFieldsLimit: 2800,
     },
     ruleChangeTracking: {
-      enabled: false,
       scope: ['security'],
     },
     invalidateApiKeysTask: {

x-pack/platform/test/alerting_api_integration/common/config.ts

@@ -42,7 +42,7 @@ interface CreateTestConfigOptions {
   maxAlerts?: number;
   emailMaximumBodyLength?: number;
   indexRefreshInterval?: string | false;
-  ruleChangeTrackingEnabled?: boolean;
+  ruleChangeTrackingScope?: string[];
 }
 
 // test.not-enabled is specifically not enabled
@@ -236,7 +236,7 @@ export function createTestConfig(name: string, options: CreateTestConfigOptions)
     experimentalFeatures = [],
     maxAlerts = 20,
     indexRefreshInterval,
-    ruleChangeTrackingEnabled = false,
+    ruleChangeTrackingScope,
   } = options;
 
   return async ({ readConfigFile }: FtrConfigProviderContext) => {
@@ -332,11 +332,8 @@ export function createTestConfig(name: string, options: CreateTestConfigOptions)
         ? []
         : [`--xpack.actions.email.maximum_body_length=${options.emailMaximumBodyLength}`];
 
-    const ruleChangeTrackingSettings = ruleChangeTrackingEnabled
-      ? [
-          '--xpack.alerting.ruleChangeTracking.enabled=true',
-          `--xpack.alerting.ruleChangeTracking.scope=${JSON.stringify(['stack'])}`,
-        ]
+    const ruleChangeTrackingSettings = ruleChangeTrackingScope
+      ? [`--xpack.alerting.ruleChangeTracking.scope=${JSON.stringify(ruleChangeTrackingScope)}`]
       : [];
 
     return {

x-pack/platform/test/alerting_api_integration/spaces_only/tests/alerting/group6/change_tracking/enabled.ts

@@ -13,7 +13,7 @@ export default function changeTrackingEnabledTest({ getService }: FtrProviderCon
   const retry = getService('retry');
 
   describe('change tracking service - enabled', () => {
-    it('should create the change history data stream when ruleChangeTracking is enabled', async () => {
+    it('should create the change history data stream for stack-scoped rule types', async () => {
       await retry.tryForTime(30_000, async () => {
         const response = await es.indices.getDataStream({ name: '.kibana_change_history' });
         expect(response.data_streams.length).to.be.greaterThan(0);

x-pack/platform/test/alerting_api_integration/spaces_only/tests/alerting/group6/config_with_change_tracking_enabled.ts

@@ -13,7 +13,7 @@ export default createTestConfig('spaces_only', {
   enableActionsProxy: false,
   verificationMode: 'none',
   useDedicatedTaskRunner: false,
-  ruleChangeTrackingEnabled: true,
+  ruleChangeTrackingScope: ['stack'],
   testFiles: [require.resolve('./change_tracking/enabled.ts')],
   reportName: 'X-Pack Alerting API Integration Tests - Change Tracking Enabled',
 });