remove kbn-change-history package FLAGS

Author: maximpn

x-pack/platform/packages/shared/kbn-change-history/index.ts

@@ -7,8 +7,3 @@
 
 export type * from './src/types';
 export * from './src/client';
-/**
- * @internal exported for test use only — do NOT use in production code,
- * this could cause the index to be created before the feature is ready for GA
- */
-export { FLAGS } from './src/constants';

x-pack/platform/packages/shared/kbn-change-history/integration_tests/client.test.ts

@@ -10,7 +10,6 @@ import { loggingSystemMock } from '@kbn/core-logging-server-mocks';
 import { ToolingLog } from '@kbn/tooling-log';
 import type { EsTestCluster } from '@kbn/test';
 import { createTestEsCluster } from '@kbn/test';
-import { FLAGS } from '../src/constants';
 import { ChangeHistoryClient } from '..';
 import { DATA_STREAM_NAME } from '../src/client';
 import type { ObjectChange } from '..';
@@ -46,7 +45,6 @@ describe('ChangeHistoryClient', () => {
   };
 
   beforeAll(async () => {
-    FLAGS.FEATURE_ENABLED = true;
     jest.setTimeout(30_000);
     esServer = createTestEsCluster({
       log: new ToolingLog({ writeTo: process.stdout, level: 'debug' }),
@@ -56,7 +54,6 @@ describe('ChangeHistoryClient', () => {
 
   afterAll(async () => {
     await esServer.stop();
-    FLAGS.FEATURE_ENABLED = false;
   });
 
   afterEach(async () => {

x-pack/platform/packages/shared/kbn-change-history/src/client.test.ts

@@ -8,7 +8,6 @@
 import { elasticsearchServiceMock } from '@kbn/core/server/mocks';
 import { loggingSystemMock } from '@kbn/core-logging-server-mocks';
 import { DataStreamClient } from '@kbn/data-streams';
-import { FLAGS } from './constants';
 import { ChangeHistoryClient } from './client';
 
 jest.mock('@kbn/data-streams', () => ({
@@ -29,7 +28,6 @@ describe('ChangeHistoryClient.initialize', () => {
   };
 
   beforeEach(() => {
-    FLAGS.FEATURE_ENABLED = true;
     DataStreamClientMock.initialize.mockResolvedValue({} as never);
   });
 

x-pack/platform/packages/shared/kbn-change-history/src/client.ts

@@ -16,13 +16,7 @@ import { type DataStreamDefinition, DataStreamClient } from '@kbn/data-streams';
 import type { ClientCreateRequest } from '@kbn/data-streams/src/types/es_api';
 import type { Logger } from '@kbn/logging';
 import { changeHistoryMappings } from './mappings';
-import {
-  FLAGS,
-  DATA_STREAM_NAME,
-  SEPARATOR_CHAR,
-  ECS_VERSION,
-  DEFAULT_RESULT_SIZE,
-} from './constants';
+import { DATA_STREAM_NAME, SEPARATOR_CHAR, ECS_VERSION, DEFAULT_RESULT_SIZE } from './constants';
 import type {
   ChangeHistoryDocument,
   GetHistoryResult,
@@ -101,11 +95,6 @@ export class ChangeHistoryClient implements IChangeHistoryClient {
    * @throws An error if the data stream is not initialized properly.
    */
   async initialize(elasticsearchClient: ElasticsearchClient) {
-    if (!FLAGS.FEATURE_ENABLED) {
-      const error = new Error(`Change history is disabled. Skipping initialization.`);
-      this.logger.error(error);
-      throw error;
-    }
     const definition: DataStreamDefinition<typeof changeHistoryMappings.v1, ChangeHistoryDocument> =
       {
         name: DATA_STREAM_NAME,

x-pack/platform/packages/shared/kbn-change-history/src/constants.ts

@@ -22,11 +22,3 @@ export const ECS_VERSION = '9.3.0';
  * The default size of results when getting history.
  */
 export const DEFAULT_RESULT_SIZE = 100;
-
-/**
- * Acts like a feature flag for this package as it prevents initialization.
- * Remove this after General Availability
- * */
-export const FLAGS = {
-  FEATURE_ENABLED: true,
-};

x-pack/platform/test/alerting_api_integration/common/plugins/alerts/server/plugin.ts

@@ -30,7 +30,6 @@ import type { IEventLogClientService, IEventLogService } from '@kbn/event-log-pl
 import type { NotificationsPluginStart } from '@kbn/notifications-plugin/server';
 import { RULE_SAVED_OBJECT_TYPE } from '@kbn/alerting-plugin/server';
 import { ALERTING_FEATURE_ID } from '@kbn/alerting-plugin/common';
-import { FLAGS as CHANGE_HISTORY_FLAGS } from '@kbn/change-history';
 import { defineRoutes } from './routes';
 import { defineActionTypes } from './action_types';
 import { defineRuleTypes } from './rule_types';
@@ -111,7 +110,6 @@ export class FixturePlugin implements Plugin<void, void, FixtureSetupDeps, Fixtu
     core: CoreSetup<FixtureStartDeps>,
     { features, actions, alerting, ruleRegistry, eventLog }: FixtureSetupDeps
   ) {
-    CHANGE_HISTORY_FLAGS.FEATURE_ENABLED = true;
     features.registerKibanaFeature({
       id: 'alertsFixture',
       name: 'Alerts',
@@ -226,7 +224,4 @@ export class FixturePlugin implements Plugin<void, void, FixtureSetupDeps, Fixtu
     this.notificationsStart$.next(notifications);
     this.notificationsStart$.complete();
   }
-  public stop() {
-    CHANGE_HISTORY_FLAGS.FEATURE_ENABLED = false;
-  }
 }