Use instanceof pattern matching

use java 16 instaceof pattern matching by automatic code clean-up in JDT
Debug.ui packages.

Author: Neethika-sumesh12

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/debug/ui/launchConfigurations/JavaJRETab.java

@@ -326,8 +326,7 @@ private IStatus checkCompliance() {
 				vm = JavaRuntime.getVMInstall(vmPath);
 			}
 			String environmentId = JavaRuntime.getExecutionEnvironmentId(vmPath);
-			if(vm instanceof AbstractVMInstall) {
-				AbstractVMInstall install = (AbstractVMInstall) vm;
+			if(vm instanceof AbstractVMInstall install) {
 				String vmver = install.getJavaVersion();
 				if(vmver != null) {
 					int val = JavaCore.compareJavaVersions(compliance, vmver);

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/debug/ui/launchConfigurations/JavaLaunchShortcut.java

@@ -289,8 +289,7 @@ public IResource getLaunchableResource(IEditorPart editorpart) {
 
 	@Override
 	public IResource getLaunchableResource(ISelection selection) {
-		if (selection instanceof IStructuredSelection) {
-			IStructuredSelection ss = (IStructuredSelection) selection;
+		if (selection instanceof IStructuredSelection ss) {
 			if (ss.size() == 1) {
 				Object element = ss.getFirstElement();
 				if (element instanceof IAdaptable) {

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/JDIElementImageDescriptor.java

@@ -73,10 +73,9 @@ protected Point getSize() {
 	 */
 	@Override
 	public boolean equals(Object object) {
-		if (!(object instanceof JDIElementImageDescriptor)) {
+		if (!(object instanceof JDIElementImageDescriptor other)) {
 			return false;
 		}
-		JDIElementImageDescriptor other = (JDIElementImageDescriptor) object;
 		return (fBaseImage.equals(other.fBaseImage) && fFlags == other.fFlags);
 	}
 

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/JDIImageDescriptor.java

@@ -99,11 +99,10 @@ protected Point getSize() {
 	 */
 	@Override
 	public boolean equals(Object object) {
-		if (!(object instanceof JDIImageDescriptor)){
+		if (!(object instanceof JDIImageDescriptor other)){
 			return false;
 		}
 
-		JDIImageDescriptor other= (JDIImageDescriptor)object;
 		return (getBaseImage().equals(other.getBaseImage()) && getFlags() == other.getFlags());
 	}
 

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/JDIModelPresentation.java

@@ -401,26 +401,23 @@ protected String getThreadText(IJavaThread thread, boolean qualified) throws Cor
 					if (exName != null) {
 						args = new String[] { thread.getName(), exName };
 					}
-				} else if (breakpoint instanceof IJavaWatchpoint) {
-					IJavaWatchpoint wp = (IJavaWatchpoint)breakpoint;
+				} else if (breakpoint instanceof IJavaWatchpoint wp) {
 					String fieldName = wp.getFieldName();
 					args = new String[] {thread.getName(), fieldName, typeName};
 					if (wp.isAccessSuspend(thread.getDebugTarget())) {
 						key.append("_fieldaccess"); //$NON-NLS-1$
 					} else {
 						key.append("_fieldmodification"); //$NON-NLS-1$
 					}
-				} else if (breakpoint instanceof IJavaMethodBreakpoint) {
-					IJavaMethodBreakpoint me= (IJavaMethodBreakpoint)breakpoint;
+				} else if (breakpoint instanceof IJavaMethodBreakpoint me) {
 					String methodName= me.getMethodName();
 					args = new String[] {thread.getName(), methodName, typeName};
 					if (me.isEntrySuspend(thread.getDebugTarget())) {
 						key.append("_methodentry"); //$NON-NLS-1$
 					} else {
 						key.append("_methodexit"); //$NON-NLS-1$
 					}
-				} else if (breakpoint instanceof IJavaLineBreakpoint) {
-					IJavaLineBreakpoint jlbp = (IJavaLineBreakpoint)breakpoint;
+				} else if (breakpoint instanceof IJavaLineBreakpoint jlbp) {
 					int lineNumber= jlbp.getLineNumber();
 					if (lineNumber > -1) {
 						args = new String[] {thread.getName(), String.valueOf(lineNumber), typeName};
@@ -1021,9 +1018,8 @@ protected Image getExpressionImage(Object expression) {
 	 */
 	private int computeJDIAdornmentFlags(Object element) {
 		try {
-			if (element instanceof IJavaThread) {
+			if (element instanceof IJavaThread javaThread) {
 				int flag= 0;
-				IJavaThread javaThread = ((IJavaThread)element);
 				if (ThreadMonitorManager.getDefault().isInDeadlock(javaThread)) {
 					flag= JDIImageDescriptor.IN_DEADLOCK;
 				}

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/LambdaUtils.java

@@ -98,10 +98,9 @@ public static IVariable findLocalVariableFromLambdaScope(IJavaStackFrame frame,
 	}
 
 	private static List<String> getArgumentTypeNames(IJavaElement parent) throws CoreException {
-		if (!(parent instanceof IMethod)) {
+		if (!(parent instanceof IMethod method)) {
 			return null;
 		}
-		IMethod method = (IMethod) parent;
 		IType type = method.getDeclaringType();
 		if (type == null) {
 			return null;

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/MemberActionFilter.java

@@ -39,8 +39,7 @@ public class MemberActionFilter implements IActionFilter {
 	@Override
 	public boolean testAttribute(Object target, String name, String value) {
 		if (name.equals("MemberActionFilter")) { //$NON-NLS-1$
-			if (target instanceof IMember) {
-				IMember member = (IMember) target;
+			if (target instanceof IMember member) {
 				if (value.equals("isRemote")) { //$NON-NLS-1$
 					IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
 					if(window != null) {
@@ -95,8 +94,7 @@ public boolean testAttribute(Object target, String name, String value) {
 					IAdaptable adapt = DebugUITools.getDebugContext();
 					if(adapt != null) {
 						IDebugTarget adapter = adapt.getAdapter(IDebugTarget.class);
-						if(adapter instanceof IJavaDebugTarget) {
-							IJavaDebugTarget dtarget = (IJavaDebugTarget) adapter;
+						if(adapter instanceof IJavaDebugTarget dtarget) {
 							return dtarget.supportsInstanceRetrieval();
 						}
 					}

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaExceptionHyperLink.java

@@ -67,8 +67,7 @@ public void linkActivated() {
 			IBreakpoint[] breakpoints = DebugPlugin.getDefault().getBreakpointManager().getBreakpoints(JDIDebugModel.getPluginIdentifier());
 			for (int i = 0; i < breakpoints.length; i++) {
 				IBreakpoint breakpoint = breakpoints[i];
-				if (breakpoint instanceof IJavaExceptionBreakpoint) {
-					IJavaExceptionBreakpoint exceptionBreakpoint = (IJavaExceptionBreakpoint) breakpoint;
+				if (breakpoint instanceof IJavaExceptionBreakpoint exceptionBreakpoint) {
 					if (fExceptionName.equals(exceptionBreakpoint.getTypeName())) {
 						// reset enabled setting to true but save original value to reset if user cancels dialog
 						exceptionBreakpoint.getMarker().setAttribute(JavaBreakpointPage.ATTR_ENABLED_SETTING_ON_CANCEL, Boolean.toString(exceptionBreakpoint.isEnabled()));

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/JREsPreferencePage.java

@@ -199,8 +199,7 @@ private void validateComplianceAndJRE(IVMInstall vmInstall) {
 		else {
 			String latest = JavaCore.getAllJavaSourceVersionsSupportedByCompiler().last();
 			String vmver = null;
-			if (vmInstall instanceof AbstractVMInstall) {
-				AbstractVMInstall vm = (AbstractVMInstall) vmInstall;
+			if (vmInstall instanceof AbstractVMInstall vm) {
 				vmver = vm.getJavaVersion();
 			}
 			if (vmver == null) {
@@ -255,8 +254,7 @@ private String getCurrentCompilerCompliance() {
 	 * @since 3.3
 	 */
 	private boolean supportsCurrentCompliance(IVMInstall vm, String compliance) {
-		if(vm instanceof AbstractVMInstall) {
-			AbstractVMInstall install = (AbstractVMInstall) vm;
+		if(vm instanceof AbstractVMInstall install) {
 			String vmver = install.getJavaVersion();
 			if(vmver == null) {
 				vmver = getVersionFromRealVM(vm);

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/LibraryContentProvider.java

@@ -117,8 +117,7 @@ public Object[] getElements(Object inputElement) {
 	 */
 	@Override
 	public Object[] getChildren(Object parentElement) {
-		if (parentElement instanceof LibraryStandin) {
-			LibraryStandin standin= (LibraryStandin) parentElement;
+		if (parentElement instanceof LibraryStandin standin) {
 			Object[] children= fChildren.get(standin);
 			if (children == null) {
 				children = new Object[] { new SubElement(standin, SubElement.SOURCE_PATH), new SubElement(standin, SubElement.JAVADOC_URL),