FP: `load_m3u8_from_s3` as static method

[daveisfera]

Was documented in #619 and is still an issue

[mcdigman]

There is a genuine false positive and/or minor internal implementation inconsistency with respect to Boto3Client, discussed below, but I'm not sure it is what you meant, because you mention load_m3u8_from_s3 specifically, and the inconsistency is papered over unless you have grep verification disabled.

Can you clarify/expand the provenance of the reproducing example/what you expect to cause load_m3u8_from_s3 to be marked as live? I don't know how it is actually used so it really looks dead to me in the example, so there must be some context I am missing, or maybe a missing file from which it would actually be called?

Minor Internal Inconsistency

If you run with --no-grep-verify enabled:

Skylos static analysis  2 issues  2 files analyzed
  unused functions: 1  unused classes: 1
  Hot directories
    . · 2 issues · 1 file · dead: 2

  02_duck_typing.py · 2 issues

    █  LOW  dead-code/class  Unused class: Boto3Client
      Dead Code  02_duck_typing.py:4
      evidence: likely dead — no static references were found [analyzer] · symbol is not exported as public API [analyzer] · no package, framework, test,...
      class Boto3Client:
      Fix: Remove the unused class if it is not public API.

    █  LOW  dead-code/function  Unused function: load_m3u8_from_s3
      Dead Code  02_duck_typing.py:12
      evidence: likely dead — no static references were found [analyzer] · symbol is not exported as public API [analyzer] · no package, framework, test,...
      def load_m3u8_from_s3(uri: str):
      Fix: Remove the unused function if it is not public API.


  ────────────────────────────────────────────────────
  2 issues   2 low 

if you run with grep verification enabled, but external_m3u8.py deleted:

    █  LOW  dead-code/function  Unused function: Boto3Client.download
      Dead Code  02_duck_typing.py:7
      evidence: likely dead — no static references were found [analyzer] · symbol is not exported as public API [analyzer] · no package, framework, test,...
      def download(uri, *_) -> tuple[str, str]:
      Fix: Remove the unused function if it is not public API.

    █  LOW  dead-code/function  Unused function: load_m3u8_from_s3
      Dead Code  02_duck_typing.py:12
      evidence: likely dead — no static references were found [analyzer] · symbol is not exported as public API [analyzer] · no package, framework, test,...
      def load_m3u8_from_s3(uri: str):
      Fix: Remove the unused function if it is not public API.

(note: the difference is the deadness changed from the class to the method)

Whereas if you run with the file present and grep verification enabled:

     Dead Code  02_duck_typing.py:12
     evidence: likely dead — no static references were found [analyzer] · symbol is not exported as public API [analyzer] · no package, framework, test,...
     def load_m3u8_from_s3(uri: str):
     Fix: Remove the unused function if it is not public API.

So the quirk is that transitive deadness marks the Boto3Client class as unused despite the usage reference, but then grep rescue rescues it from the exact same usage reference it already suppressed. If that is the intended behavior, then potentially more stable behavior would be for transitive deadness to never have suppressed it in the first place.

However, leaving grep verification enabled (as it is by default) papers over the minor internal inconsistency.

[duriantaco]

I checked the repro, but I cant find anything that calls or registers load_m3u8_from_s3. I can see how Boto3Client.download gets called once the wrapper runs, but nothing currently causes the wrapper itself to run.

Could you add the real call or registration from your project to the repro below? then we can see exactly what Skylos is missing so we can issue the fix. thanks