Fixed coding standards.

Author: AlexSkrypnyk

.github/workflows/test.yml

@@ -48,14 +48,19 @@ jobs:
           ini-values: pcov.directory=.
 
       - name: Install dependencies
-        run: composer install
+        run: |
+          if [ "${{ matrix.php-versions }}" == "8.2" ]; then
+            composer remove --dev drevops/phpcs-standard --no-update
+          fi
+          composer install
 
       - name: Validate composer.json
         run: |
           composer --verbose validate
           composer normalize --dry-run
 
       - name: Check coding standards
+        if: matrix.php-versions == '8.3'
         run: composer lint
         continue-on-error: ${{ vars.CI_LINT_IGNORE_FAILURE == '1' }}
 

composer.json

@@ -19,20 +19,17 @@
         "symfony/http-client": "^6.0 || ^7.0"
     },
     "require-dev": {
-        "bamarni/composer-bin-plugin": "^1.8",
         "behat/mink-browserkit-driver": "^2.2",
         "dantleech/gherkin-lint": "^0.2.3",
         "dealerdirect/phpcodesniffer-composer-installer": "^1",
         "dmore/behat-chrome-extension": "^1.4",
         "drevops/behat-phpserver": "^2.0",
+        "drevops/phpcs-standard": "^0.2.0",
         "drupal/coder": "^8.3",
         "dvdoug/behat-code-coverage": "^5.3",
         "ergebnis/composer-normalize": "^2.44",
-        "escapestudios/symfony2-coding-standard": "^3",
         "lullabot/mink-selenium2-driver": "^1.7",
         "lullabot/php-webdriver": "^2.0.4",
-        "mikey179/vfsstream": "^1.6",
-        "opis/closure": "^4.0",
         "php-mock/php-mock-phpunit": "^2.13",
         "phpstan/phpstan": "^2",
         "phpunit/phpunit": "^11",
@@ -51,7 +48,6 @@
     },
     "config": {
         "allow-plugins": {
-            "bamarni/composer-bin-plugin": true,
             "dealerdirect/phpcodesniffer-composer-installer": true,
             "ergebnis/composer-normalize": true
         },

phpcs.xml

@@ -10,6 +10,12 @@
     <rule ref="Generic.PHP.RequireStrictTypes">
         <exclude-pattern>BehatCliContext\.php</exclude-pattern>
     </rule>
+    <rule ref="DrevOps.NamingConventions.LocalVariableSnakeCase">
+        <exclude-pattern>BehatCliContext\.php</exclude-pattern>
+    </rule>
+    <rule ref="DrevOps.NamingConventions.ParameterSnakeCase">
+        <exclude-pattern>BehatCliContext\.php</exclude-pattern>
+    </rule>
 
     <!-- Show sniff codes in all reports -->
     <arg value="s"/>

src/DrevOps/BehatScreenshotExtension/Context/ScreenshotContext.php

@@ -766,7 +766,7 @@ public function renderInfo(): string {
 
     // Use a non-HTML output to make this output universal.
     return implode("\n", array_map(
-      fn($key, $value): string => sprintf('%s: %s', $key, $value),
+      fn(string $key, $value): string => sprintf('%s: %s', $key, $value),
       array_keys($this->info),
       $this->info,
     ));

tests/behat/bootstrap/BehatCliTrait.php

@@ -76,13 +76,13 @@ public function behatCliWriteFeatureContextFile(array $traits = []): string {
       '{{USE_IN_CLASS}}' => '',
     ];
     foreach ($traits as $path => $trait) {
-      $traitName = $trait;
+      $trait_name = $trait;
       if (strpos($trait, '\\') !== FALSE) {
         $tokens['{{USE_DECLARATION}}'] .= sprintf('use %s;' . PHP_EOL, $trait);
-        $traitNameParts = explode('\\', $trait);
-        $traitName = end($traitNameParts);
+        $trait_name_parts = explode('\\', $trait);
+        $trait_name = end($trait_name_parts);
       }
-      $tokens['{{USE_IN_CLASS}}'] .= sprintf('use %s;' . PHP_EOL, $traitName);
+      $tokens['{{USE_IN_CLASS}}'] .= sprintf('use %s;' . PHP_EOL, $trait_name);
 
       if (is_string($path) && file_exists($path)) {
         $filename = $this->workingDir . DIRECTORY_SEPARATOR . 'features/bootstrap/' . basename($path);
@@ -182,11 +182,11 @@ public function behatCliWriteScenarioSteps(PyStringNode $content, string $tags =
     $content = strtr((string) $content, ["'''" => '"""']);
 
     // Make sure that indentation in provided content is accurate.
-    $contentLines = explode(PHP_EOL, $content);
-    foreach ($contentLines as $k => $contentLine) {
-      $contentLines[$k] = str_repeat(' ', 4) . trim($contentLine);
+    $content_lines = explode(PHP_EOL, $content);
+    foreach ($content_lines as $k => $content_line) {
+      $content_lines[$k] = str_repeat(' ', 4) . trim($content_line);
     }
-    $content = implode(PHP_EOL, $contentLines);
+    $content = implode(PHP_EOL, $content_lines);
 
     $tokens = [
       '{{SCENARIO_CONTENT}}' => $content,
@@ -333,16 +333,16 @@ public function behatCliWriteScreenshotTestContext(PyStringNode $content): void
     }
 
     // Update the behat.yml to include this context.
-    $behatYmlPath = $this->workingDir . DIRECTORY_SEPARATOR . 'behat.yml';
-    if (file_exists($behatYmlPath)) {
-      $behatYml = file_get_contents($behatYmlPath);
-      if (strpos($behatYml, 'FullscreenTestContext') === FALSE) {
-        $behatYml = str_replace(
+    $behat_yml_path = $this->workingDir . DIRECTORY_SEPARATOR . 'behat.yml';
+    if (file_exists($behat_yml_path)) {
+      $behat_yml = file_get_contents($behat_yml_path);
+      if (strpos($behat_yml, 'FullscreenTestContext') === FALSE) {
+        $behat_yml = str_replace(
           'ScreenshotContext',
           "ScreenshotContext\n        - FullscreenTestContext",
-          $behatYml
+          $behat_yml
         );
-        file_put_contents($behatYmlPath, $behatYml);
+        file_put_contents($behat_yml_path, $behat_yml);
       }
     }
   }