Improve code quality and fix PHPUnit configuration

Signed-off-by: Alex Skrypnyk <alex@drevops.com>

Author: AlexSkrypnyk

CLAUDE.md

@@ -0,0 +1,44 @@
+# Claude Code Configuration
+
+## Standard Operations
+
+These are the standard operations that should be performed when working with this codebase:
+
+### Code Quality Checks
+```
+composer lint       # Run all linting tools
+composer lint-fix   # Automatically fix linting issues 
+composer test       # Run PHPUnit tests without coverage
+```
+
+### Coding Standards
+- Follow Drupal coding standards
+- Use snake_case for variable names (e.g., `$file_path` not `$filePath`)
+- Use TRUE/FALSE constants (uppercase) rather than true/false
+- Use NULL constant (uppercase) rather than null
+- Maintain proper docblock annotations
+
+### PHPUnit Configuration
+- Uses PHPUnit 11.5 with configuration in phpunit.xml
+- Coverage reports are generated in .logs/coverage directory
+
+## Recent Improvements
+- Updated autoloader from PSR-0 to PSR-4
+- Made constants public as per PHP 8.2+ standards
+- Improved error messages for file operations
+- Optimized token replacement logic
+- Updated PHPUnit configuration to remove deprecated attributes
+- Ensured all variables follow Drupal's snake_case naming convention
+
+## Code Structure
+The Behat Screenshot extension provides functionality to capture screenshots during Behat test runs. Its main components are:
+
+1. **BehatScreenshotExtension**: Handles configuration and service container integration
+2. **ScreenshotContext**: Provides Behat steps and screenshot capabilities
+3. **Tokenizer**: Processes dynamic filename generation with tokens
+
+## Best Practices for Contributing
+1. Always run tests before and after changes
+2. Maintain existing code style and standards
+3. Fix PHPUnit deprecations as they arise
+4. Use verbose error messages to aid debugging

composer.json

@@ -39,8 +39,8 @@
         "symfony/process": "^6.4 || ^7.0"
     },
     "autoload": {
-        "psr-0": {
-            "DrevOps\\BehatScreenshot": "src/"
+        "psr-4": {
+            "DrevOps\\BehatScreenshotExtension\\": "src/DrevOps/BehatScreenshotExtension"
         }
     },
     "autoload-dev": {

phpunit.xml

@@ -1,6 +1,5 @@
-<?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.3/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd"
          bootstrap="vendor/autoload.php"
          cacheDirectory=".phpunit.cache"
          executionOrder="depends,defects"
@@ -12,21 +11,20 @@
          displayDetailsOnTestsThatTriggerWarnings="true"
          displayDetailsOnTestsThatTriggerErrors="true"
          displayDetailsOnTestsThatTriggerNotices="true"
->
+         displayDetailsOnTestsThatTriggerDeprecations="true">
     <testsuites>
         <testsuite name="default">
             <directory>tests/phpunit</directory>
         </testsuite>
     </testsuites>
-
-    <source restrictDeprecations="true" restrictNotices="true" restrictWarnings="true">
+    <source restrictNotices="true"
+            restrictWarnings="true"
+            ignoreIndirectDeprecations="true">
         <include>
             <directory>src</directory>
         </include>
     </source>
-
     <coverage includeUncoveredFiles="true"
-              pathCoverage="false"
               ignoreDeprecatedCodeUnits="true"
               disableCodeCoverageIgnore="false">
         <report>

src/DrevOps/BehatScreenshotExtension/Context/ScreenshotContext.php

@@ -236,9 +236,12 @@ public function iSaveSizedScreenshot(string|int $width = 1440, string|int $heigh
    */
   public function saveScreenshotContent(string $filename, string $content): void {
     (new Filesystem())->mkdir($this->dir, 0755);
-    $success = file_put_contents($this->dir . DIRECTORY_SEPARATOR . $filename, $content);
+    $file_path = $this->dir . DIRECTORY_SEPARATOR . $filename;
+    $success = file_put_contents($file_path, $content);
     if ($success === FALSE) {
-      throw new \RuntimeException(sprintf('Failed to save screenshot to %s', $filename));
+      // @codeCoverageIgnoreStart
+      throw new \RuntimeException(sprintf('Failed to save screenshot to %s. Check permissions and disk space.', $file_path));
+      // @codeCoverageIgnoreEnd
     }
   }
 

src/DrevOps/BehatScreenshotExtension/ServiceContainer/BehatScreenshotExtension.php

@@ -20,7 +20,7 @@ class BehatScreenshotExtension implements ExtensionInterface {
   /**
    * Extension configuration ID.
    */
-  const MOD_ID = 'drevops_behat_screenshot';
+  public const MOD_ID = 'drevops_behat_screenshot';
 
   /**
    * {@inheritdoc}

src/DrevOps/BehatScreenshotExtension/Tokenizer.php

@@ -33,13 +33,10 @@ public static function replaceTokens(string $text, array $data = []): string {
 
     // Move {step_name} token to the last position as it may contain other
     // tokens.
-    foreach ($replacements as $name => $value) {
-      if ($name === '{step_name}') {
-        $replaced = [$name => $value];
-        unset($replacements[$name]);
-        $replacements = array_merge($replacements, $replaced);
-        break;
-      }
+    if (isset($replacements['{step_name}'])) {
+      $step_name_value = $replacements['{step_name}'];
+      unset($replacements['{step_name}']);
+      $replacements['{step_name}'] = $step_name_value;
     }
 
     return strtr($text, $replacements);