Skip to content

Commit 9781805

Browse files
committed
Adjust unit tests
1 parent 9edc3be commit 9781805

1 file changed

Lines changed: 18 additions & 3 deletions

File tree

test/python/WMCore_t/MicroService_t/MSRuleCleaner_t/MSRuleCleaner_t.py

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
# system modules
1111
import os
1212
import unittest
13+
import tracemalloc
1314

1415
# WMCore modules
1516
from WMCore.MicroService.MSRuleCleaner.MSRuleCleaner import MSRuleCleaner, MSRuleCleanerArchivalSkip
@@ -392,9 +393,23 @@ def testPipelineArchiveStepChain(self):
392393
with self.assertRaises(MSRuleCleanerArchivalSkip):
393394
self.msRuleCleaner.plineArchive.run(wflow)
394395

395-
def testRunning(self):
396-
result = self.msRuleCleaner._execute(self.reqRecords)
397-
self.assertEqual(result, (3, 2, 0, 0))
396+
def testMemoryLeak(self):
397+
"""
398+
unit test for measuring potential memory leak in MSRuleCleanerWflow
399+
"""
400+
tracemalloc.start()
401+
MSRuleCleanerWflow(self.taskChainReq)
402+
current, peak = tracemalloc.get_traced_memory()
403+
tracemalloc.stop()
404+
self.assertTrue(abs(peak-current), 100)
405+
406+
# now let's test if we have memory leak in a loop
407+
tracemalloc.start()
408+
for _ in range(1000):
409+
MSRuleCleanerWflow(self.taskChainReq)
410+
current, peak = tracemalloc.get_traced_memory()
411+
tracemalloc.stop()
412+
self.assertTrue(abs(peak-current), 100)
398413

399414
def testCheckClean(self):
400415
# NOTE: All of the bellow checks are well visualized at:

0 commit comments

Comments
 (0)