[feature] Ablity to also set `'Ignore text'` filter to also `Remove text` (checkbox)?

[dgtlmoon]

#2899 related

If there was a checkbox under "Ignore text" text filter to also remove the text it would be nice

currently "ignore text" is also included in the snapshot (its just ignored for the purpose of detecting the change)

[gety9]

@dgtlmoon #3006 is different issue, i am not using "ignore text" at all.

[gety9]

@dgtlmoon

finally i figured out what causing the issue #3006

It's "text filtering > remove lines" checkbox

if "remove lines" is checked then snapshot is generated correctly:
settings

snapshot

if it's unchecked, then snapshot will miss not changed lines
settings

snapshot

[dgtlmoon]

@gety9

Note: Depending on the length and similarity of the text on each line, the algorithm may consider an addition instead of replacement for example.
So it's always better to select Added+Replaced when you're interested in new content.
When content is merely moved in a list, it will also trigger an addition, consider enabling Only trigger when unique lines appear

thats why this text is there, i have no control over exactly what it will calculate as 'remove', it depends on the mathmatetics/algorithm

[gety9]

@dgtlmoon

"thats why this text is there"
-, i always use "added + replace", it says nothing about "removed"

"i have no control over exactly what it will calculate as 'remove'"
-, you want to say that in my bug screenshots not shown lines were calculated as "removed"? and that's why they are not shown?

that will also mean that "limit trigger/ignore/block/extract to":
settings is also applied to snapshot? It doesn't make any sense - snapshot is state of the page. (it can't depend on added, replaced, removed - cause they are themselved determinted as function taking into 2 states (previous & current snapshots))

[dgtlmoon]

-, you want to say that in my bug screenshots not shown lines were calculated as "removed"? and that's why they are not shown?

Correct, I have no other information to go on, you didnt supply any backups, I dont know the URL you are watching, you didnt share the 'share url' link

[gety9]

@dgtlmoon

you didnt supply any backups

i supplied backup Jan 19th #2908 (comment)

I dont know the URL you are watching

it's on ALL urls, on ANY watch (js, non-js - all) (as soon as i uncheck "Removed lines" next snapshot will have missing lines (not changed lines will be calculated as removed))

[Roukanken42]

What's happening?

This issue should actually happen with any of the detection options set differently from default.
What's happening is, that for example, with "Ignore removed lines" set, you can see the following behavior:

First snapshot:

1
2
3

Then page changes to something that would produce snapshot

1
2
3
4

But the actual snapshot that will get saved to user-facing History, is

4

Which is very confusing to users expecting to see all 4 lines. This then results in the History/notification diff showing very weird results.

Why does this happen?

I think the culprit is this if block, which gets triggered if any special diffing is set. It should correctly generate a text on which md5 detection will properly check the requested properties, as if compared with the altered diff algorithm, but this altered text then gets passed further, being treated as the extracted text.

This will effectively remove any "same lines" from any of the user-facing snapshots, excluding the first one, resulting in this confusing behavior.

[dgtlmoon]

@Roukanken42

I think the culprit is this if block, which gets triggered if any special diffing is set.

yes exactly :) here's the fix #3561 :)

[dgtlmoon]

ok and now there is a 'strip ignored lines from content' checkbox in filter, so i'll close this