Skip to content

Fix when scan incorrect doc cause memory crash #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BootKitS wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix when scan incorrect doc cause memory crash #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion olefile/olefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,12 +618,16 @@ def __init__(self, fp, sect, size, offset, sectorsize, fat, filesize, olefileio)
log.debug('nb_sectors = %d' % nb_sectors)
# This number should (at least) be less than the total number of
# sectors in the given FAT:
data = []
if nb_sectors > len(fat):
self.ole._raise_defect(DEFECT_INCORRECT, 'malformed OLE document, stream too large')
data = b"".join(data)
io.BytesIO.__init__(self, data)
return
# optimization(?): data is first a list of strings, and join() is called
# at the end to concatenate all in one string.
# (this may not be really useful with recent Python versions)
data = []

# if size is zero, then first sector index should be ENDOFCHAIN:
if size == 0 and sect != ENDOFCHAIN:
log.debug('size == 0 and sect != ENDOFCHAIN:')
Expand Down