Action will download artifacts from all tries on re-ran jobs

[matejdro]

When using the action from on: workflow_run:

      - name: Download and Extract Artifacts
        uses: dawidd6/action-download-artifact@9dde25e7413c6123b6062d4c9fc954d6ff005cfc
        continue-on-error: true
        id: download
        with:
          run_id: ${{ github.event.workflow_run.id }}
          path: artifacts
          allow_forks: true

and the originating workflow is re-ran, this action will:

1. Download artifacts from both runs (the original run and the re-ran one)
2. Even worse: artifacts may not be in the right order (e.g. it may first download the one from the newer run and then the one from the older run, overriding the new artifacts).

Is there a way to prevent this?

[matejdro]

The proper solution here would probably be the ability to specify attempt in addition to run_id:

      - name: Download and Extract Artifacts
        uses: dawidd6/action-download-artifact@9dde25e7413c6123b6062d4c9fc954d6ff005cfc
        continue-on-error: true
        id: download
        with:
          run_id: ${{ github.event.workflow_run.id }}
          run_attempt: ${{ github.event.workflow_run.run_attempt }}
          path: artifacts
          allow_forks: true

[dawidd6]

Care to open a PR?

[matejdro]

Sure, can do that at some point.