[BUG?] Incorrect icons in custom menu.

[Allonny]

Rofi version (rofi -v or git commit in case of build issue)

2.0.0

Configuration

https://gist.github.com/Allonny/e9d366c2c88520e230d54853821bd0a5

Theme

https://gist.github.com/Allonny/9265bcbb7a0fc772728d259e9bef3e7a

Timing report

No response

Launch command

https://gist.github.com/Allonny/56e5f884395a2de14fdf1cf1137784d7

Step to reproduce

1. Install papirus-icon-theme from repo
2. Place the theme files powermenu.rasi, colors.rasi, and font.rasi (the contents are in the Gist after the output of rasi -dump-theme) in ~/.config/rofi/
3. Run the script provided in the Gist, which is attached in the Launch command field.

Expected behavior

I selected the icons in the Papirus theme folder, and inserted their names into the corresponding menu item lines in the script. The thumbnails show that all the icons are solid-color and light, as they should be.

Script fragment with icon names:

lock_icon="\0icon\x1fsystem-lock-screen"
hibernate_icon="\0icon\x1fsystem-hibernate"
logout_icon="\0icon\x1fsystem-log-out"
reboot_icon="\0icon\x1fsystem-reboot"
shutdown_icon="\0icon\x1fsystem-shutdown"
update_icon="\0icon\x1fsystem-upgrade"
cancel_icon="\0icon\x1fundo"

Actual behavior

Icons displayed in the Rofi menu.

Additional information

Hello!
This has probably already been resolved somewhere, but I ran into the following problem and couldn't find a solution myself.
The gist is this: I wrote a small script for the power menu, and I want icons from the Papirus-Dark theme to display next to the menu items. I explicitly specified this theme in the .rasi configuration file, set the icon size to 24x24, and am specifying my favorite icons in the menu bars, but the icons displayed are completely different.
This problem arose, I think, over a year ago. The icons were fine before, but after another update—I'm not sure if it was Papirus, Rofi, or something else—it broke. I just ignored it back then and didn't pay attention, but now I've gotten around to figuring it out. Initially, I was using symbolic icons, and before the crash, they displayed normally (meaning they were light). But after the crash, some of them seemed to have been taken from the light theme variation (meaning they were dark). However, now I've looked directly at the theme files, and the Papirus developers actually inserted symbolic links from the light version even for the dark theme. But then I looked at the regular versions, and they're fine and suitable for me. I selected them, but instead, some colored icons are displayed that I couldn't even find. I understand that these are my skill issues, but I don't even understand how to address them.

PS: While writing this text and filling out the required fields for the application, I realized that I'm apparently using the Rofi theme tools incorrectly...

I've checked if the issue exists in the latest stable release

• Yes, I have checked the problem exists in the latest stable version

[DaveDavenport]

Please check with G_MESSAGES_DEBUG=Helpers.IconFetcher set to see what icon it loads.

For me it loads:
(process:42988): Helpers.IconFetcher-DEBUG: 18:40:56.099: found icon system-lock-screen(24x24): /usr/share/icons/Papirus-Dark/24x24/categories/system-lock-screen.svg

that is a color icon.

[Allonny]

Yes, it looks like rofi is taking icons from 32x32/categories.
How can I explicitly specify a relative path to the icon files (not an absolute one, in case I want to change the icon theme)? And why is it taking 32x32 icons when the icon size in the theme is set to 24x24?

https://gist.github.com/Allonny/4fa89916acc0a6ccb1e842e2fb9165f7

[DaveDavenport]

Not sure why, but it seems it wants 29x29 pixel icons, so it takes the one size up and scales it down.
(some icon drawing stuff with this got fixed in git, so I am not sure if this is fixed already, I got 24x24 pixels when I tried).

We currently do not have an option to pick context for the icon (action/categories/etc). We only support the symbolic icon by specifying to <icon-name>-symbolic.
We currently follow the order of contexts the icon-theme specifies, when searching the right entry.

[Allonny]

What could theoretically be the reason for the icon size being set to 29? I even tried reducing the size of both the icons themselves in the theme file and the element block, but they still have the same colored 29x29 icons.

[DaveDavenport]

The colored-ness of the icons has nothing to do with the size.
It has to do with https://xdg-specs-swick-795ea8a62c27711dcb7f70c91799f1b3f1c9140fe547f5a.pages.freedesktop.org/icon-naming-spec/0.4/ar01s02.html

It evaluates this order based on what the theme specified, so it takes the categories first (and those on my system are all colored icons.) So rofi is loading the right icons (but that might not be what you want).

I looked a bit into the size of the icon and this is a "bug", it currently takes (for element-icon, as this is 'special') the size of the widget (so that is size + margins) for looking up the icon, this is wrong. It does look like it scales it down to fit within the margins again. It should not really affect things visual to much.

We are currently working on a patch (redraw-fixes branch) that should resolve this once merged.

[DaveDavenport]

you can see if the symbolic icons fit better for you use:

system-lock-screen-symbolic

[DaveDavenport]

diff --git a/source/view.c b/source/view.c
index 30689ae7..084d485b 100644
--- a/source/view.c
+++ b/source/view.c
@@ -26,6 +26,7 @@
  */

 /** The Rofi View log domain */
+#include "widgets/widget-internal.h"
 #define G_LOG_DOMAIN "View"

 #include <config.h>
@@ -712,7 +713,7 @@ static void update_callback(textbox *t, icon *ico, unsigned int index,
     (*type) |= fstate;

     if (ico) {
-      int icon_height = widget_get_desired_height(WIDGET(ico), WIDGET(ico)->w);
+      int icon_height = widget_padding_get_remaining_height(WIDGET(ico));
       cairo_surface_t *surf_icon =
           mode_get_icon(state->sw, state->line_map[index], icon_height);
       icon_set_surface(ico, surf_icon);

this might be a workaround for it.

[Allonny]

Yes, as I mentioned earlier, I've used symbolic icons before, and they generally work. The only problem is apparently either the theme developers or the XBPS packagers have a problem. The dark theme uses dark icons for symbolic icons, meaning the symlinks from the light theme are setted. This problem doesn't exist in other icon themes, so I'll stick with them for now.
Anyway, thanks a lot for your help!

[Allonny]

Should I close this issue?