Skip to content

Commit de14e5b

Browse files
committed
make the test deterministic
pyspark does not guarantee row ordering. comparing dataframes is cleaner approach
1 parent 2284449 commit de14e5b

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

tests/test_metastore.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
StructField,
66
StructType,
77
)
8+
from pyspark.testing import assertDataFrameEqual
89
from pytest import fixture, raises
910

1011
from pysparkdt import reinit_local_metastore, spark_base
@@ -41,7 +42,7 @@ def test_reinit_requires_exactly_one_source():
4142
def test_table_factories(spark: SparkSession):
4243
reinit_local_metastore(spark, table_factories={TEST_TABLE: _build_table})
4344

44-
rows = spark.read.format('delta').table(TEST_TABLE).collect()
45-
assert len(rows) == 2
46-
assert rows[0].id == 0
47-
assert rows[0].name == 'a'
45+
actual = spark.read.format('delta').table(TEST_TABLE)
46+
expected = _build_table(spark)
47+
assertDataFrameEqual(actual, expected)
48+

0 commit comments

Comments
 (0)