fix(database): add migration for missing contact_private_info table

[thepastaclaw]

Issue

Fixes #686

Description

Users with existing databases get "no such table: contact_private_info" errors because contact_private_info was only created in create_tables() (fresh installs) but had no migration step in apply_version_changes().

Fix

Added migration version 29 that calls init_contacts_tables(). Uses CREATE TABLE IF NOT EXISTS so it's idempotent and safe for all database states (fresh installs already have the table; upgraders will get it via migration).

Testing

• cargo check ✅
• All 41 database tests pass

Summary by CodeRabbit

• Chores
  • Updated database to version 29 with refined migration handling for data initialization.

[thepastaclaw]

@coderabbitai review

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 356a0732-9c89-40b9-a7d0-c8cd4862f6c0

📥 Commits

Reviewing files that changed from the base of the PR and between 768a834 and 3812b9d.

📒 Files selected for processing (1)

• src/database/initialization.rs

---

📝 Walkthrough

Walkthrough

Database default version bumped from 28 to 29. The init_contacts_tables() initialization call is relocated from the version 28 migration path to a new version 29 path, deferring table creation to the later migration version. This addresses table initialization sequencing in the database schema.

Changes

Cohort / File(s)	Summary
Database Version & Migration Logic src/database/initialization.rs	Incremented DEFAULT_DB_VERSION constant from 28 to 29; relocated init_contacts_tables(tx) call from version 28 branch to newly added version 29 migration path to defer contact table initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• fix(db): add missing contact_private_info table to migration 28 #702: Directly modifies the same migration logic for init_contacts_tables, adding it to version 28 path while this PR moves it to version 29, representing coordinated schema evolution changes.

Poem

🐰 From v28 to v29 we hopscotch true,
Tables sprout where they ought to grew,
Contacts saved through migration's song,
Database woes corrected long! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a migration for the missing contact_private_info table.
Linked Issues check	✅ Passed	The PR addresses issue #686 by implementing a migration to ensure the contact_private_info table exists for upgraded databases.
Out of Scope Changes check	✅ Passed	All changes are directly related to the migration objective; only the database version constant and migration logic were modified.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[lklimek]

already fixed in base branch, v28