fix(ci): statically link MinGW runtime for Windows builds (#769)

* fix(ci): statically link MinGW runtime for Windows builds

Adds -static-libgcc, -static-libstdc++, and static winpthread rustflags
for the x86_64-pc-windows-gnu target so the Windows binary no longer
depends on MinGW runtime DLLs absent on user machines. Also sets
OPENSSL_STATIC=1 on the build step to statically link OpenSSL.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(ci): bundle SQLite statically and add Windows binary sanity check

- Add `bundled` feature to rusqlite so SQLite is compiled from source
  and statically linked, eliminating the sqlite3.dll dependency
- Remove the Windows libsql CI step that downloaded sqlite3.dll and
  created an import library with a broken (null) DLL name entry
- Add post-build verification step that inspects the PE import table
  and fails if null DLL imports or MinGW runtime DLLs are found

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: fix wallet UTXO tests for bundled SQLite FK enforcement

Insert the wallet record before the address row in `register_test_address`
so the `addresses.seed_hash` FK (enforced when SQLite is compiled with
`SQLITE_DEFAULT_FOREIGN_KEYS=1` via the `bundled` feature) is satisfied.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: lklimek

.cargo/config.toml

@@ -10,6 +10,7 @@ rustflags = ["-C", "target-feature=-crt-static", "-C", "target-cpu=x86-64"]
 [target.x86_64-pc-windows-gnu]
 linker = "x86_64-w64-mingw32-gcc-posix"
 ar = "x86_64-w64-mingw32-ar"
+rustflags = ["-C", "link-args=-static-libgcc -static-libstdc++ -Wl,-Bstatic -lpthread -Wl,-Bdynamic"]
 
 [env]
 CC_x86_64_pc_windows_gnu = "x86_64-w64-mingw32-gcc-posix"

.github/workflows/release.yml

@@ -94,15 +94,32 @@ jobs:
         env:
           PROTOC: /usr/local/bin/protoc
 
-      - name: Windows libsql
-        if: ${{ matrix.target == 'x86_64-pc-windows-gnu' }}
-        run: curl -OL https://www.sqlite.org/2024/sqlite-dll-win-x64-3460100.zip && sudo unzip -o sqlite-dll-win-x64-3460100.zip -d winlibs && sudo chown -R runner:docker winlibs/ && pwd && ls -lah && cd winlibs && x86_64-w64-mingw32-dlltool -d sqlite3.def -l libsqlite3.a && ls -lah && cd .. && sudo cp winlibs/libsqlite3.a /usr/x86_64-w64-mingw32/lib/libsqlite3.a
-
       - name: Build project
         run: |
           cargo build --release --target ${{ matrix.target }}
           mv target/${{ matrix.target }}/release/dash-evo-tool${{ matrix.ext }} dash-evo-tool/dash-evo-tool${{ matrix.ext }}
-          if [ -f winlibs/sqlite3.dll ]; then cp winlibs/sqlite3.dll dash-evo-tool/sqlite3.dll; fi
+        env:
+          OPENSSL_STATIC: "1"
+
+      - name: Verify Windows binary is self-contained
+        if: ${{ matrix.target == 'x86_64-pc-windows-gnu' }}
+        run: |
+          echo "Checking DLL imports..."
+          IMPORTS=$(x86_64-w64-mingw32-objdump -p dash-evo-tool/dash-evo-tool.exe | grep "DLL Name:" | sort -u)
+          echo "$IMPORTS"
+          # Fail if any null DLL imports (broken import table)
+          if echo "$IMPORTS" | grep -q "(null)"; then
+            echo "::error::Binary has null DLL imports — broken import table detected"
+            exit 1
+          fi
+          # Fail if MinGW runtime DLLs are dynamically linked
+          for dll in libgcc_s_seh-1.dll libwinpthread-1.dll libstdc++-6.dll; do
+            if echo "$IMPORTS" | grep -qi "$dll"; then
+              echo "::error::Binary dynamically links $dll — must be statically linked"
+              exit 1
+            fi
+          done
+          echo "✅ Binary is self-contained — no MinGW runtime or null DLL dependencies"
 
       - name: Package release
         run: |

Cargo.lock

@@ -52,7 +52,7 @@ arboard = { version = "3.6.0", default-features = false, features = [
     "windows-sys",
 ] }
 directories = "6.0.0"
-rusqlite = { version = "0.38.0", features = ["functions", "fallible_uint"] }
+rusqlite = { version = "0.38.0", features = ["bundled", "functions", "fallible_uint"] }
 dark-light = "2.0.0"
 image = { version = "0.25.6", default-features = false, features = [
     "png",

Cargo.toml

@@ -2752,6 +2752,8 @@ mod tests {
     /// Helper: register a wallet address in the test database so that
     /// `update_address_balance` can find the row.
     fn register_test_address(db: &Database, wallet: &Wallet, address: &Address) {
+        db.store_wallet(wallet, &Network::Testnet)
+            .expect("store test wallet");
         let seed_hash = wallet.seed_hash();
         let path = DerivationPath::from(vec![
             ChildNumber::Hardened { index: 44 },